Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AAP-23818] Credentials plugins wizard test button #2327

Merged
merged 2 commits into from
May 23, 2024
Merged

[AAP-23818] Credentials plugins wizard test button #2327

merged 2 commits into from
May 23, 2024

Conversation

skochay330
Copy link
Member

@skochay330 skochay330 commented May 16, 2024 •
edited

This PR adds 'test' button to the credentials plugins wizard

Jira issue: https://issues.redhat.com/browse/AAP-23818

Screenshot 2024-05-21 at 5 50 18 PM

@github-actions github-actions bot added the AWX Label to indicate changes relevant to AWX label May 16, 2024
@skochay330 skochay330 force-pushed the AAP-23818_credential-plugins-wizard-test-button branch from 3c7c6ca to f65e838 Compare May 21, 2024 21:48
@skochay330 skochay330 changed the title [WIP][AAP-23818] Credentials plugins wizard test button [AAP-23818] Credentials plugins wizard test button May 21, 2024
@skochay330 skochay330 marked this pull request as ready for review May 21, 2024 21:52
kialam
kialam requested changes May 21, 2024
View reviewed changes
Copy link
Member

@kialam kialam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far. I would move the toast alert into the credentials plugin modal rather than passing it down and remove the unnecessary else statement.

frontend/awx/access/credentials/CredentialForm.tsx Outdated Show resolved Hide resolved
frontend/awx/access/credentials/CredentialForm.tsx Outdated Show resolved Hide resolved
frontend/awx/access/credentials/CredentialPlugins/CredentialPlugins.tsx Outdated Show resolved Hide resolved
frontend/awx/access/credentials/CredentialPlugins/hooks/useCredentialPluginsDialog.tsx Outdated Show resolved Hide resolved
frontend/awx/access/credentials/CredentialPlugins/hooks/useCredentialPluginsDialog.tsx Show resolved Hide resolved
frontend/awx/access/credentials/CredentialPlugins/hooks/useCredentialPluginsDialog.tsx Show resolved Hide resolved
frontend/awx/access/credentials/CredentialPlugins/hooks/useCredentialPluginsDialog.tsx Show resolved Hide resolved
frontend/awx/access/credentials/CredentialPlugins/hooks/useCredentialPluginsDialog.tsx Outdated Show resolved Hide resolved
frontend/awx/access/credentials/CredentialPlugins/hooks/useCredentialPluginsDialog.tsx Outdated Show resolved Hide resolved
frontend/awx/access/credentials/CredentialPlugins/hooks/useCredentialPluginsDialog.tsx Outdated Show resolved Hide resolved
@skochay330 skochay330 force-pushed the AAP-23818_credential-plugins-wizard-test-button branch 2 times, most recently from 028eb65 to bd92d47 Compare May 22, 2024 14:21
kialam
kialam approved these changes May 22, 2024
View reviewed changes
Copy link
Member

@kialam kialam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be good to go once the alert toaster is moved into their respective useCredentialPluginsModal and useCredentialTestModal hooks. ⭐

@skochay330 skochay330 force-pushed the AAP-23818_credential-plugins-wizard-test-button branch 3 times, most recently from 4bbe6f7 to 340a9b3 Compare May 22, 2024 21:49
@skochay330 skochay330 force-pushed the AAP-23818_credential-plugins-wizard-test-button branch from 340a9b3 to 1a74036 Compare May 22, 2024 22:06
@skochay330 skochay330 merged commit 0a1c2f1 into main May 23, 2024
17 checks passed
@skochay330 skochay330 deleted the AAP-23818_credential-plugins-wizard-test-button branch May 23, 2024 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kialam kialam kialam approved these changes

Assignees
No one assigned
Labels
AWX Label to indicate changes relevant to AWX
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@skochay330 @kialam