Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update AWX roles lists #2330

Merged
merged 4 commits into from
May 21, 2024
Merged

Update AWX roles lists #2330

merged 4 commits into from
May 21, 2024

Conversation

keithjgrant
Copy link
Member

Use new RBAC resources for Roles and Teams->Roles lists

@github-actions github-actions bot added the AWX Label to indicate changes relevant to AWX label May 16, 2024
@keithjgrant keithjgrant force-pushed the 20236-awx-roles-update branch 3 times, most recently from 4ab010c to ce66360 Compare May 17, 2024 23:26
vidyanambiar
vidyanambiar requested changes May 20, 2024
View reviewed changes
Copy link
Member

@vidyanambiar vidyanambiar left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Can we have the associated permissions for a role displayed in an expanded row (similar to EDA)?

  • There is an error on pagination to page 3

image

frontend/awx/access/teams/TeamPage/TeamRoles.tsx
pageNavigate(AwxRoute.AddRolesToTeam, { params: { id: team.id } })
}
{...view}
<ResourceAccess
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a heads up - this particular change is related to a work item that @ZitaNemeckova will be addressing AAP-20560

@keithjgrant
Copy link
Member Author

  • There is an error on pagination to page 3

Looks like this was caused by the System Auditor role, which has no content_type field. I added a catch to cast that to "null" for the sake of the URL. Do you know if this just happens to be bad data in our environment?

@vidyanambiar
Copy link
Member

vidyanambiar commented May 21, 2024 •
edited

@keithjgrant The System Auditor role is unique in that it has a null content-type because it is applicable system-wide. This is expected.

vidyanambiar
vidyanambiar approved these changes May 21, 2024
View reviewed changes
Copy link
Member

@vidyanambiar vidyanambiar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! 🎉

It would be good to get some component tests added.

@keithjgrant keithjgrant merged commit f1ac7ce into main May 21, 2024
2 checks passed
@keithjgrant keithjgrant deleted the 20236-awx-roles-update branch May 21, 2024 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vidyanambiar vidyanambiar vidyanambiar approved these changes

Assignees
No one assigned
Labels
AWX Label to indicate changes relevant to AWX
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@keithjgrant @vidyanambiar