Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python 3.8 unit test timeout with coverage #58413

Closed
mattclay opened this issue Jun 26, 2019 · 5 comments · Fixed by #59733
Closed

Python 3.8 unit test timeout with coverage #58413

mattclay opened this issue Jun 26, 2019 · 5 comments · Fixed by #59733
Assignees
@samdoran
Labels
affects_2.9 This issue/PR affects Ansible v2.9 bug This issue/PR relates to a bug. python3 support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
Test Queue

Comments

@mattclay
Copy link
Member

SUMMARY

The nightly CI runs with code coverage are timing out for Python 3.8 unit tests:

https://app.shippable.com/github/ansible/ansible/runs/129532/10/console

ISSUE TYPE

Bug Report

COMPONENT NAME

unit tests

ANSIBLE VERSION

devel

CONFIGURATION

N/A

OS / ENVIRONMENT

Shippable

STEPS TO REPRODUCE

Run unit tests on Python 3.8 with code coverage enabled on Shippable.

EXPECTED RESULTS

Tests pass.

ACTUAL RESULTS

Tests time out.
@mattclay mattclay added this to To do in Broken Tests via automation Jun 26, 2019
@ansibot
Copy link
Contributor

ansibot commented Jun 26, 2019

Files identified in the description:
None

If these files are inaccurate, please update the component name section of the description or use the !component bot command.

click here for bot help

@ansibot ansibot added affects_2.9 This issue/PR affects Ansible v2.9 bug This issue/PR relates to a bug. needs_triage Needs a first human triage before being processed. python3 support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Jun 26, 2019
@mattclay mattclay removed this from To do in Broken Tests Jun 26, 2019
@mattclay mattclay added this to To do in Test Queue via automation Jun 26, 2019
@mattclay mattclay removed the needs_triage Needs a first human triage before being processed. label Jun 26, 2019
@jborean93
Copy link
Contributor

Could be related to #58415 (comment). Will wait until Python 3.8.0b2 is out before trying that out and see if the issue still exists.

@samdoran
Copy link
Contributor

Still an issue with Python 3.8.0b2.

@samdoran samdoran moved this from To do to In progress in Test Queue Jul 18, 2019
@nitzmahone
Copy link
Member

nitzmahone commented Jul 25, 2019 •
edited

I've narrowed this down to coverage breaking multiprocessing under Python3.8 and filed a bug on that project with a minimal standalone repro: nedbat/coveragepy#828

This was referenced Jul 26, 2019
Closed
Merged
Test Queue automation moved this from In progress to Done Jul 29, 2019
@samdoran
Copy link
Contributor

Fixed in coverage 4.5.4.

@ansible ansible locked and limited conversation to collaborators Aug 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@samdoran samdoran

Labels
affects_2.9 This issue/PR affects Ansible v2.9 bug This issue/PR relates to a bug. python3 support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
No open projects
Test Queue
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update constraints for coverage on Python 3.8 samdoran/ansible
5 participants
@mattclay @samdoran @ansibot @nitzmahone @jborean93