Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update constraints for coverage on Python 3.8 #59733

Merged
merged 1 commit into from Jul 29, 2019
Merged

Update constraints for coverage on Python 3.8 #59733

merged 1 commit into from Jul 29, 2019

Conversation

samdoran
Copy link
Contributor

@samdoran samdoran commented Jul 29, 2019 •
edited

SUMMARY

A bug in coverage caused units tests to hang in Python 3.8 when running with coverage enabled. This was fixed in coverage 4.5.4.

Fixes #58415
Fixes #58413

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

test/runner/requirements/constraints.txt

@samdoran samdoran requested a review from mattclay July 29, 2019 16:49
@ansibot
Copy link
Contributor

ansibot commented Jul 29, 2019

cc @mattclay
click here for bot help

@ansibot ansibot added affects_2.9 This issue/PR affects Ansible v2.9 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. needs_triage Needs a first human triage before being processed. python3 support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests. labels Jul 29, 2019
@ansibot
Copy link
Contributor

ansibot commented Jul 29, 2019

cc @mattclay
click here for bot help

@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Jul 29, 2019
@samdoran samdoran changed the title Update constraints for coverage or Python 3.8 Update constraints for coverage on Python 3.8 Jul 29, 2019
@samdoran
Copy link
Contributor Author

Test failures are unrelated to this PR (that failure is fixed in #59742).

@samdoran samdoran merged commit ed4a729 into ansible:devel Jul 29, 2019
@samdoran samdoran deleted the ci/coverage-constraints branch July 29, 2019 20:05
samdoran added a commit to samdoran/ansible that referenced this pull request Jul 29, 2019
@samdoran
[stable-2.8] Update constraints for coverage on Python 3.8 (ansible#5…
be9c2ff 
…9733)

This fixes the unit tests hanging when run with Python 3.8 with coverage enabled
(cherry picked from commit ed4a729)

Co-authored-by: Sam Doran <sdoran@redhat.com>
@samdoran samdoran mentioned this pull request Jul 29, 2019
Merged
@mattclay mattclay removed the needs_triage Needs a first human triage before being processed. label Jul 29, 2019
abadger pushed a commit that referenced this pull request Jul 31, 2019
@samdoran @abadger
[stable-2.8] Update constraints for coverage on Python 3.8 (#59733)
fd7b423 
This fixes the unit tests hanging when run with Python 3.8 with coverage enabled
(cherry picked from commit ed4a729)

Co-authored-by: Sam Doran <sdoran@redhat.com>
@ansible ansible locked and limited conversation to collaborators Aug 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mattclay mattclay mattclay left review comments

Assignees
No one assigned
Labels
affects_2.9 This issue/PR affects Ansible v2.9 bug This issue/PR relates to a bug. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. python3 support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Python 3.8 win_ping test timeout Python 3.8 unit test timeout with coverage
3 participants
@samdoran @ansibot @mattclay