node assignment configs are attached on all k8s workloads #1853
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -20,9 +20,33 @@ spec: | |||
| resources: | |||
| {{ backup_resource_requirements | to_nice_yaml(indent=2) | indent(width=6, first=False) }} | |||
| {%- endif %} | |||
| {% if db_management_pod_node_selector %} | |||
| {% if task_node_selector %} | |||
There was a problem hiding this comment.
@ranvit The task_node_selector parameter only exists in the installer role (AWX CR), not in the back role (AWXBackup CR).
So db_management_pod_node_selector is correct.
If you need topologySpreadConstraints, tolerations, and affinity as well, those params would need to be added to the AWXBackup CR and should be prefixed with db_management_pod_*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
The db migration pod and the backup process pod have failed to schedule on a k8s cluster where every node has a taint. So this PR adds the task_* related node-assignment params and the global node-assignment params as fallback to every k8s workload that didn't have node-assignment configuration available on them.
This fixes issues like #1774
ISSUE TYPE
ADDITIONAL INFORMATION
I PR'd a similar fix with #1804, only targeting the migration pod. Realised I need somethign similar on the backup pod.
The task_* params seem well suited for most of the k8s workloads except for the mesh-ingress deployment, so I had that only use the global params