[WIP] Encrypt extra_data to not expose things that might be used by authenticators
#378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a user logs in through an authenticator we capture information about the login into a field called extra_data. The authenticator (ldap/keycloak/github/any others) could add sensitive information which is then plain text in the database.
This PR encrypts that data before it goes in to the database and includes test coverage for those functions.
I also included an update to the requirements file for the dev environment as they are needed for testing/migration making for test app. I can split those out into a separate PR if needed. Django is pinned to the same versions that are required for regular install.
Testing Steps