fix: correct line number processing #113
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes bug which prevented logging of errors on line 0.
| if (matches) { | ||
| let message = matches.groups?.message ?? "unknown"; | ||
| let line = parseInt(matches.groups?.line ?? "1") - 1; | ||
| let line = parseInt(matches.groups?.line ?? "0"); |
There was a problem hiding this comment.
Do you have a test for this?
There was a problem hiding this comment.
In fact I have no tests and this will soon come to hunt me. If one of you could add even a sample test I could start adding tests. The reason for not adding tests is because I not dot know how to write them for extensions.
Anyway, this morning I proved that there is no bug in the extension and was caused by ansible/ansible-lint#1556 -- the linter will be released soon.
There was a problem hiding this comment.
IIRC the last time I had to setup tests I followed https://code.visualstudio.com/api/working-with-extensions/testing-extension
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes bug which prevented logging of errors on line 0.