fix: Typography dynamic of copyable & eidtable (#48350)

* fix: editable should show * test: test driven * fix: copyable of render
ant-design · Apr 9, 2024 · 44cd534 · 44cd534
1 parent 727aa2d
commit 44cd534
Show file tree

Hide file tree

Showing 3 changed files with 25 additions and 1 deletion.
diff --git a/components/typography/Base/index.tsx b/components/typography/Base/index.tsx
@@ -487,7 +487,7 @@ const Base = React.forwardRef<HTMLElement, BlockProps>((props, ref) => {
               width={ellipsisWidth}
               onEllipsis={onJsEllipsis}
               expanded={expanded}
-              miscDeps={[copied, expanded, copyLoading]}
+              miscDeps={[copied, expanded, copyLoading, enableEdit, enableCopy]}
             >
               {(node, canEllipsis) => {
                 let renderNode: React.ReactNode = node;

diff --git a/components/typography/__tests__/copy.test.tsx b/components/typography/__tests__/copy.test.tsx
@@ -316,4 +316,16 @@ describe('Typography copy', () => {
 
     spy.mockRestore();
   });
+
+  it('dynamic set editable', () => {
+    const { container, rerender } = render(<Base component="p">test</Base>);
+    expect(container.querySelector('.ant-typography-copy')).toBeFalsy();
+
+    rerender(
+      <Base component="p" copyable>
+        test
+      </Base>,
+    );
+    expect(container.querySelector('.ant-typography-copy')).toBeTruthy();
+  });
 });
diff --git a/components/typography/__tests__/editable.test.tsx b/components/typography/__tests__/editable.test.tsx
@@ -78,4 +78,16 @@ describe('Typography.Editable', () => {
 
     unmount();
   });
+
+  it('dynamic set editable', () => {
+    const { container, rerender } = render(<Base component="p">test</Base>);
+    expect(container.querySelector('.ant-typography-edit')).toBeFalsy();
+
+    rerender(
+      <Base component="p" editable>
+        test
+      </Base>,
+    );
+    expect(container.querySelector('.ant-typography-edit')).toBeTruthy();
+  });
 });