fix: Result should hide icon when it is falsy

close #38484
ant-design · Nov 10, 2022 · c3767f3 · c3767f3
1 parent 8af0b4f
commit c3767f3
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 0 deletions.
diff --git a/components/result/__tests__/index.test.tsx b/components/result/__tests__/index.test.tsx
@@ -67,4 +67,11 @@ describe('Result', () => {
 
     warnSpy.mockRestore();
   });
+
+  it('should hide icon by setting icon to false or null', () => {
+    const { container } = render(<Result title="404" icon={null} />);
+    expect(container.querySelectorAll('.ant-result-icon')).toHaveLength(0);
+    const { container: container2 } = render(<Result title="404" icon={false} />);
+    expect(container2.querySelectorAll('.ant-result-icon')).toHaveLength(0);
+  });
 });
diff --git a/components/result/index.tsx b/components/result/index.tsx
@@ -73,10 +73,15 @@ const Icon: React.FC<IconProps> = ({ prefixCls, icon, status }) => {
       </div>
     );
   }
+
   const iconNode = React.createElement(
     IconMap[status as Exclude<ResultStatusType, ExceptionStatusType>],
   );
 
+  if (icon === null || icon === false) {
+    return icon;
+  }
+
   return <div className={className}>{icon || iconNode}</div>;
 };