Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow vertical gutter for Row component #16728

Closed
1 task done
webberwang opened this issue May 22, 2019 · 1 comment
Closed
1 task done

Allow vertical gutter for Row component #16728

webberwang opened this issue May 22, 2019 · 1 comment
Labels
help wanted The suggestion or request has been accepted, we need you to help us by sending a pull request. Inactive

Comments

@webberwang
Copy link

webberwang commented May 22, 2019

  • I have searched the issues of this repository and believe that this is not a duplicate.

A previous issue has been closed but is unresolved #4410

What problem does this feature solve?

Allows a common use case where we want to apply margin so Card components have vertical space between them. Adding margin on the bottom doesn't work as nicely because the last row will have extra margin padding.

We'll need to use nth pseudo-selector to remove margin on last row, which adds much more complexity when considering responsiveness, as difference screen sizes will have a different number of elements per row.

What does the proposed API look like?

<Row vgutter={8}></Row>
@afc163 afc163 added the help wanted The suggestion or request has been accepted, we need you to help us by sending a pull request. label Jul 22, 2019
@afc163
Copy link
Member

afc163 commented Sep 24, 2019

#18979 merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted The suggestion or request has been accepted, we need you to help us by sending a pull request. Inactive
Projects
None yet
Development

No branches or pull requests

4 participants