feat: Grid support row vertical gutter #18979
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![tests-checker[bot]](https://avatars.githubusercontent.com/in/17064?s=60&v=4){kind=small}
|
Deploy preview for ant-design ready! Built with commit 00f6b3a |
shaodahong
reviewed
Sep 24, 2019
components/config-provider/__tests__/__snapshots__/components.test.js.snap
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## feature #18979 +/- ##
===========================================
+ Coverage 96.95% 96.95% +<.01%
===========================================
Files 281 281
Lines 7577 7593 +16
Branches 2116 2128 +12
===========================================
+ Hits 7346 7362 +16
Misses 229 229
Partials 2 2
Continue to review full report at Codecov.
|
afc163
approved these changes
Sep 24, 2019
1 task
afc163
reviewed
Oct 20, 2019
| for (let i = 0; i < responsiveArray.length; i++) { | ||
| const breakpoint: Breakpoint = responsiveArray[i]; | ||
| if (this.state.screens[breakpoint] && g[breakpoint] !== undefined) { | ||
| gutter[index] = g[breakpoint] as number; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 This is a ...
🔗 Related issue link
#16728
💡 Background and solution
Row添加垂直间距支持
📝 Changelog
☑️ Self Check before Merge
View rendered components/grid/demo/gutter.md
View rendered components/grid/demo/playground.md
View rendered components/grid/index.en-US.md
View rendered components/grid/index.zh-CN.md