Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CompoundedComponent and DropdownInterface is not exported which results in error ts(4032) #38824

Closed
ctretyak opened this issue Nov 21, 2022 · 6 comments · Fixed by #39060
Closed
Labels
help wanted The suggestion or request has been accepted, we need you to help us by sending a pull request.

Comments

@ctretyak
Copy link

ctretyak commented Nov 21, 2022

Reproduction link

Edit on CodeSandbox

Steps to reproduce

Wrap Button component into styled (styled-components)

What is expected?

No error

What is actually happening?

We are exporting component that using an interface that hadn't exported and in result we have error Exported variable 'ButtonStyled' has or is using name 'CompoundedComponent' from external module "/sandbox/node_modules/antd/es/button/button" but cannot be named.ts(4023)

Environment Info
antd 5.0.0
React react
System Windows 10
Browser Chrome
@afc163
Copy link
Member

afc163 commented Nov 21, 2022

Is it fixed in #38666 ?

@ctretyak
Copy link
Author

Is it fixed in #38666 ?

partly. With Button it will be ok. But I don't see any fix on DropdownInterface

@MadCcc MadCcc added the help wanted The suggestion or request has been accepted, we need you to help us by sending a pull request. label Nov 22, 2022
@github-actions
Copy link
Contributor

Hello @ctretyak. We totally like your proposal/feedback, welcome to send us a Pull Request for it. Please send your Pull Request to proper branch (feature branch for the new feature, master for bugfix and other changes), fill the Pull Request Template here, provide changelog/TypeScript/documentation/test cases if needed and make sure CI passed, we will review it soon. We appreciate your effort in advance and looking forward to your contribution!

你好 @ctretyak,我们完全同意你的提议/反馈,欢迎直接在此仓库 创建一个 Pull Request 来解决这个问题。请将 Pull Request 发到正确的分支(新特性发到 feature 分支,其他发到 master 分支),务必填写 Pull Request 内的预设模板,提供改动所需相应的 changelog、TypeScript 定义、测试用例、文档等,并确保 CI 通过,我们会尽快进行 Review,提前感谢和期待您的贡献。

giphy

@xhxe
Copy link

xhxe commented Nov 22, 2022

remove "declaration": true from tsconfig.json and it will disappear the error

@ctretyak
Copy link
Author

remove "declaration": true from tsconfig.json and it will disappear the error

Of course, but if I need it?

@xhxe
Copy link

xhxe commented Nov 22, 2022

thats good issue, if CompoundedComponent and DropdownInterface had exports that would fix that error easily doing like this

import { CompoundedComponent } from 'antd/lib/button/button';

export const SButton: CompoundedComponent = styled(Button)``

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted The suggestion or request has been accepted, we need you to help us by sending a pull request.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants