Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(type): replace interface with type for export component #39060

Merged
merged 1 commit into from Dec 1, 2022

Conversation

wangcch
Copy link
Contributor

@wangcch wangcch commented Nov 28, 2022

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

#38666
close #38824

💡 Background and solution

check all /^interface \w+ extends/

📝 Changelog

Language Changelog
🇺🇸 English Fix interface type error from external module
🇨🇳 Chinese 补充修复暴露组建的内部类型依赖报错

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@github-actions
Copy link
Contributor

github-actions bot commented Nov 28, 2022

@codecov
Copy link

codecov bot commented Nov 28, 2022

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (ecb36d4) compared to base (4efa3b2).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff            @@
##            master    #39060   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          545       545           
  Lines         9361      9361           
  Branches      2653      2653           
=========================================
  Hits          9361      9361           
Impacted Files Coverage Δ
components/skeleton/Skeleton.tsx 100.00% <ø> (ø)
components/statistic/Countdown.tsx 100.00% <ø> (ø)
components/statistic/Statistic.tsx 100.00% <ø> (ø)
components/breadcrumb/BreadcrumbItem.tsx 100.00% <100.00%> (ø)
components/breadcrumb/BreadcrumbSeparator.tsx 100.00% <100.00%> (ø)
components/collapse/Collapse.tsx 100.00% <100.00%> (ø)
components/dropdown/dropdown-button.tsx 100.00% <100.00%> (ø)
components/dropdown/dropdown.tsx 100.00% <100.00%> (ø)
components/empty/index.tsx 100.00% <100.00%> (ø)
components/form/FormItem/index.tsx 100.00% <100.00%> (ø)
... and 2 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@MadCcc MadCcc merged commit 337703d into ant-design:master Dec 1, 2022
@wangcch wangcch deleted the fix-compounded-component-type-2 branch December 1, 2022 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CompoundedComponent and DropdownInterface is not exported which results in error ts(4032)
2 participants