Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Descriptions组件不设置label的显示问题 #17337

Merged
merged 2 commits into from
Jun 27, 2019
Merged

fix: Descriptions组件不设置label的显示问题 #17337

merged 2 commits into from
Jun 27, 2019

Conversation

xuqiang1227
Copy link

@xuqiang1227 xuqiang1227 commented Jun 27, 2019

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

👻 What's the background?

close #17290

💡 Solution

📝 Changelog

Language Changelog
🇺🇸 English
🇨🇳 Chinese

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Copy link

@tests-checker tests-checker bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add tests to make sure this change works as expected?

@netlify
Copy link

netlify bot commented Jun 27, 2019

Deploy preview for ant-design ready!

Built with commit 6575501

https://deploy-preview-17337--ant-design.netlify.com

@codecov
Copy link

codecov bot commented Jun 27, 2019

Codecov Report

Merging #17337 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #17337   +/-   ##
=======================================
  Coverage   95.95%   95.95%           
=======================================
  Files         263      263           
  Lines        7351     7351           
  Branches     2015     2042   +27     
=======================================
  Hits         7054     7054           
  Misses        295      295           
  Partials        2        2
Impacted Files Coverage Δ
components/descriptions/index.tsx 98.66% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4463d24...6575501. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Jun 27, 2019

Codecov Report

Merging #17337 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #17337   +/-   ##
=======================================
  Coverage   95.95%   95.95%           
=======================================
  Files         263      263           
  Lines        7351     7351           
  Branches     2015     2042   +27     
=======================================
  Hits         7054     7054           
  Misses        295      295           
  Partials        2        2
Impacted Files Coverage Δ
components/descriptions/index.tsx 98.66% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4463d24...6575501. Read the comment docs.

@afc163 afc163 changed the title Fix Descriptions组件不设置label的显示问题 #17290 fix: Descriptions组件不设置label的显示问题 Jun 27, 2019
@afc163 afc163 merged commit b0fb533 into ant-design:master Jun 27, 2019
@afc163 afc163 mentioned this pull request Jun 29, 2019
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Descriptions组件不设置label的显示问题
2 participants