Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ms_MY locale support #17546

Merged
merged 3 commits into from
Jul 15, 2019
Merged

Added ms_MY locale support #17546

merged 3 commits into from
Jul 15, 2019

Conversation

austin-krave
Copy link

@austin-krave austin-krave commented Jul 9, 2019

πŸ€” This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (Added new locale support)

πŸ‘» What's the background?

  1. Missing ms_MY locale support

πŸ’‘ Solution

  1. Added ms_MY locale support for locale-provider, time-picker, date-picker, tests

πŸ“ Changelog

Language Changelog
πŸ‡ΊπŸ‡Έ English πŸ‡²πŸ‡Ύ Add locale Malay.
πŸ‡¨πŸ‡³ Chinese πŸ‡²πŸ‡Ύ ζ–°ε’žι©¬ζ₯θ―­θ―­θ¨€εŒ…γ€‚

β˜‘οΈ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@afc163
Copy link
Member

afc163 commented Jul 9, 2019

rebase feature to fix ci

@codecov
Copy link

codecov bot commented Jul 10, 2019

Codecov Report

Merging #17546 into feature will decrease coverage by 0.02%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff             @@
##           feature   #17546      +/-   ##
===========================================
- Coverage    96.04%   96.01%   -0.03%     
===========================================
  Files          267      269       +2     
  Lines         7430     7432       +2     
  Branches      2073     2075       +2     
===========================================
  Hits          7136     7136              
- Misses         292      294       +2     
  Partials         2        2
Impacted Files Coverage Ξ”
components/time-picker/locale/ms_MY.tsx 0% <0%> (ΓΈ)
components/date-picker/locale/ms_MY.tsx 0% <0%> (ΓΈ)

Continue to review full report at Codecov.

Legend - Click here to learn more
Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data
Powered by Codecov. Last update 34e2491...52e5439. Read the comment docs.

@codecov
Copy link

codecov bot commented Jul 10, 2019

Codecov Report

Merging #17546 into feature will decrease coverage by 0.02%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff             @@
##           feature   #17546      +/-   ##
===========================================
- Coverage    96.04%   96.01%   -0.03%     
===========================================
  Files          268      269       +1     
  Lines         7434     7432       -2     
  Branches      2037     2075      +38     
===========================================
- Hits          7140     7136       -4     
- Misses         292      294       +2     
  Partials         2        2
Impacted Files Coverage Ξ”
components/time-picker/locale/ms_MY.tsx 0% <0%> (ΓΈ)
components/date-picker/locale/ms_MY.tsx 0% <0%> (ΓΈ)
components/descriptions/Col.tsx
components/descriptions/index.tsx 98.93% <0%> (+0.14%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data
Powered by Codecov. Last update f17073e...44e4567. Read the comment docs.

@austin-krave
Copy link
Author

@afc163 is the 0% of diff hit for codecov/patch normal?

@afc163
Copy link
Member

afc163 commented Jul 11, 2019

test case needed

@afc163
Copy link
Member

afc163 commented Jul 12, 2019

@afc163
Copy link
Member

afc163 commented Jul 15, 2019

image

@austin-krave
Copy link
Author

@afc163 I believe I have done npm test -- -u, the commit i have pushed was "44e4567-rerun tests", i think this problem happens after I rebase feature branch again, let me rerun the test again and see whether i have anything to commit and push

@afc163 afc163 merged commit 7d9af06 into ant-design:feature Jul 15, 2019
@austin-krave
Copy link
Author

@afc163 Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants