Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Descriptions support colon props #17560

Merged
merged 3 commits into from
Jul 11, 2019
Merged

feat: Descriptions support colon props #17560

merged 3 commits into from
Jul 11, 2019

Conversation

hengkx
Copy link
Member

@hengkx hengkx commented Jul 10, 2019

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

👻 What's the background?

💡 Solution

ref #17497

image

📝 Changelog

Language Changelog
🇺🇸 English Descriptions add colon props
🇨🇳 Chinese Descriptions 增加colon属性

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

View rendered components/descriptions/index.en-US.md
View rendered components/descriptions/index.zh-CN.md

Copy link

@tests-checker tests-checker bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add tests to make sure this change works as expected?

@codecov
Copy link

codecov bot commented Jul 10, 2019

Codecov Report

Merging #17560 into feature will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           feature   #17560      +/-   ##
===========================================
+ Coverage    96.04%   96.04%   +<.01%     
===========================================
  Files          267      268       +1     
  Lines         7430     7434       +4     
  Branches      2073     2037      -36     
===========================================
+ Hits          7136     7140       +4     
  Misses         292      292              
  Partials         2        2
Impacted Files Coverage Δ
components/descriptions/Col.tsx 100% <100%> (ø)
components/descriptions/index.tsx 98.79% <100%> (-0.15%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 34e2491...628dbc2. Read the comment docs.

@lgtm-com
Copy link

lgtm-com bot commented Jul 10, 2019

This pull request introduces 1 alert when merging 99a2cc2 into 34e2491 - view on LGTM.com

new alerts:

  • 1 for Useless conditional

@afc163 afc163 changed the title feat:Descriptions support colon props feat: Descriptions support colon props Jul 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants