Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Table getPopupContainer #17806

Merged
merged 4 commits into from
Jul 23, 2019
Merged

feat: Table getPopupContainer #17806

merged 4 commits into from
Jul 23, 2019

Conversation

afc163
Copy link
Member

@afc163 afc163 commented Jul 22, 2019

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

close #17548
close #16876
close #14864
close #14426

💡 Background and solution

Expose this function for various of situation.

📝 Changelog

Language Changelog
🇺🇸 English
🇨🇳 Chinese - Table 新增 getPopupContainer 属性用于设置表格内的各类浮层渲染节点。
- 修复 ConfigProvider getPopupContainer 对 Table 不生效的问题。

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

View rendered components/table/index.en-US.md
View rendered components/table/index.zh-CN.md

@netlify
Copy link

netlify bot commented Jul 22, 2019

Deploy preview for ant-design ready!

Built with commit efecf5e

https://deploy-preview-17806--ant-design.netlify.com

@codecov
Copy link

codecov bot commented Jul 22, 2019

Codecov Report

Merging #17806 into feature will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           feature   #17806      +/-   ##
===========================================
- Coverage    96.13%   96.13%   -0.01%     
===========================================
  Files          270      270              
  Lines         7461     7459       -2     
  Branches      2045     2087      +42     
===========================================
- Hits          7173     7171       -2     
  Misses         286      286              
  Partials         2        2
Impacted Files Coverage Δ
components/table/filterDropdown.tsx 96.63% <ø> (+1.59%) ⬆️
components/table/Table.tsx 93.78% <100%> (+0.17%) ⬆️
components/_util/wave.tsx 85.84% <0%> (-2.84%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 42468b6...abcfe77. Read the comment docs.

@codecov
Copy link

codecov bot commented Jul 22, 2019

Codecov Report

Merging #17806 into feature will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           feature   #17806      +/-   ##
===========================================
+ Coverage    96.13%   96.15%   +0.01%     
===========================================
  Files          270      270              
  Lines         7461     7460       -1     
  Branches      2045     2088      +43     
===========================================
  Hits          7173     7173              
+ Misses         286      285       -1     
  Partials         2        2
Impacted Files Coverage Δ
components/table/filterDropdown.tsx 96.63% <ø> (+1.59%) ⬆️
components/table/Table.tsx 93.79% <100%> (+0.18%) ⬆️
components/_util/wave.tsx 85.84% <0%> (-2.84%) ⬇️
components/config-provider/index.tsx 97.05% <0%> (+2.94%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 42468b6...efecf5e. Read the comment docs.

@zombieJ
Copy link
Member

zombieJ commented Jul 22, 2019

ConfigProvider?

@buildsize
Copy link

buildsize bot commented Jul 23, 2019

File name Previous Size New Size Change
package-lock.json 854.27 KB 856.06 KB 1.79 KB (0%)

dropdownPrefixCls: string;
columns: ColumnProps<T>[];
locale: TableLocale;
getPopupContainer: TableProps<T>['getPopupContainer'];
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

改成 object 参数声明形式,增减参数比较方便。

@afc163 afc163 merged commit 161def0 into feature Jul 23, 2019
@delete-merged-branch delete-merged-branch bot deleted the feat-table-popup-container branch July 23, 2019 05:46
@ikobe-zz ikobe-zz mentioned this pull request Aug 4, 2019
14 tasks
@lizhandong
Copy link

请问antd 3.x Table组件的getPopupContainer为什么会没有效果呢?我看到源码好像是有提供的

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants