Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ConfigProvider support locale #17816

Merged
merged 12 commits into from
Jul 24, 2019
Merged

feat: ConfigProvider support locale #17816

merged 12 commits into from
Jul 24, 2019

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented Jul 23, 2019

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

ref #16911

💡 Background and solution

Merge LocaleProvider into ConfigProvider

📝 Changelog

Language Changelog
🇺🇸 English Merge LocaleProvider into ConfigProvider
🇨🇳 Chinese 将 LocaleProvider 合并入 ConfigProvider

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

View rendered components/config-provider/demo/all.md
View rendered components/config-provider/index.en-US.md
View rendered components/config-provider/index.zh-CN.md
View rendered components/date-picker/index.en-US.md
View rendered components/date-picker/index.zh-CN.md
View rendered components/locale-provider/index.en-US.md
View rendered components/locale-provider/index.zh-CN.md
View rendered docs/react/faq.zh-CN.md
View rendered docs/react/getting-started.zh-CN.md
View rendered docs/react/i18n.en-US.md
View rendered docs/react/i18n.zh-CN.md

@pr-triage pr-triage bot added the PR: draft label Jul 23, 2019
@netlify
Copy link

netlify bot commented Jul 23, 2019

Deploy preview for ant-design ready!

Built with commit 59265b0

https://deploy-preview-17816--ant-design.netlify.com

@codecov
Copy link

codecov bot commented Jul 23, 2019

Codecov Report

Merging #17816 into feature will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           feature   #17816      +/-   ##
===========================================
+ Coverage    96.06%   96.06%   +<.01%     
===========================================
  Files          271      271              
  Lines         7475     7479       +4     
  Branches      2091     2079      -12     
===========================================
+ Hits          7181     7185       +4     
  Misses         292      292              
  Partials         2        2
Impacted Files Coverage Δ
components/table/Table.tsx 93.6% <ø> (ø) ⬆️
components/modal/locale.tsx 100% <ø> (ø) ⬆️
components/upload/Upload.tsx 95.16% <ø> (ø) ⬆️
components/transfer/index.tsx 95.48% <ø> (ø) ⬆️
components/popconfirm/index.tsx 100% <ø> (ø) ⬆️
components/config-provider/index.tsx 94.11% <100%> (ø) ⬆️
components/locale-provider/index.tsx 91.66% <100%> (+0.75%) ⬆️
components/_util/warning.tsx 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bdea770...59265b0. Read the comment docs.

docs/react/faq.zh-CN.md Outdated Show resolved Hide resolved
@@ -3,6 +3,9 @@ import * as PropTypes from 'prop-types';
import * as moment from 'moment';
import interopDefault from '../_util/interopDefault';
import { ModalLocale, changeConfirmLocale } from '../modal/locale';
import warning from '../_util/warning';

export const ANT_MARK = 'internalMark';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

是不是可以用 Symbol

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IE 不支持 Symbol

Copy link
Member

@afc163 afc163 Jul 23, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

不是有 babel runtime 转过

@zombieJ zombieJ marked this pull request as ready for review July 23, 2019 09:58
@zombieJ
Copy link
Member Author

zombieJ commented Jul 23, 2019

Done. Please check. @afc163

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants