Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: the DatePicker border bug when the chose was century #17887

Merged
merged 3 commits into from
Jul 30, 2019
Merged

fix: the DatePicker border bug when the chose was century #17887

merged 3 commits into from
Jul 30, 2019

Conversation

xrkffgg
Copy link
Member

@xrkffgg xrkffgg commented Jul 25, 2019

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

#17879

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English fix: the DatePicker border bug when the chose was century
🇨🇳 Chinese DatePicker:修复当选择条件为世纪时,border 不对齐的样式 bug

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@netlify
Copy link

netlify bot commented Jul 25, 2019

Deploy preview for ant-design ready!

Built with commit aa7f5fb

https://deploy-preview-17887--ant-design.netlify.com

@buildsize
Copy link

buildsize bot commented Jul 25, 2019

File name Previous Size New Size Change
package-lock.json 855.38 KB 861.43 KB 6.05 KB (1%)

@codecov
Copy link

codecov bot commented Jul 25, 2019

Codecov Report

Merging #17887 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #17887   +/-   ##
=======================================
  Coverage   96.06%   96.06%           
=======================================
  Files         268      268           
  Lines        7467     7467           
  Branches     2087     2087           
=======================================
  Hits         7173     7173           
  Misses        292      292           
  Partials        2        2

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e62daf...aa7f5fb. Read the comment docs.

@xrkffgg xrkffgg changed the title DatePicker:修复当选择条件为世纪时,border 不对齐的样式 bug fix: the DatePicker border bug when the chose was century Jul 26, 2019
@afc163
Copy link
Member

afc163 commented Jul 29, 2019

Good job!

This problem exists in DatePicker too (the height of century panel header is 1px lower than other panels), could you help to fix it?

图片

@xrkffgg
Copy link
Member Author

xrkffgg commented Jul 29, 2019

@afc163 Hi 我修复的就是这个问题。DatePicker 里 选择条件是世纪的时候,hearder 像素底的问题。效果图如下:

修复前:
before

修复后:
after

@xrkffgg
Copy link
Member Author

xrkffgg commented Jul 30, 2019

@afc163
又 commit 了一下,这次改动是,加上了 选择条件为 decade 时,border 调整。

第一种是都去掉了,然后都上移了 1px

我想既然做了这样的定义,原设计师 应该是想要 使用下移 1px,所以调整为 世纪选择时,也下移 1px

@afc163
Copy link
Member

afc163 commented Jul 30, 2019

我的意思是,除了 RangePicker,DatePicker 里的世纪面板/年月面板也有这个 1px 的偏差问题,切换的时候能看出来抖动,方便的话可以帮忙一起修掉。😊

@xrkffgg
Copy link
Member Author

xrkffgg commented Jul 30, 2019

@afc163 😂😂😂 一直在关注范围选取,单个的没注意到。没有比较,不仔细看,确实很容易忽略。

@afc163 afc163 merged commit 7588dda into ant-design:master Jul 30, 2019
@ikobe-zz ikobe-zz mentioned this pull request Aug 4, 2019
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants