Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Input clear icon align problem #18151

Merged
merged 2 commits into from Aug 8, 2019
Merged

Conversation

afc163
Copy link
Member

@afc163 afc163 commented Aug 7, 2019

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

close #18150
close #17414

💡 Background and solution

解决了 https://codesandbox.io/s/wizardly-sun-u10br 这里的各种错位问题,也检查了 #15237 避免改错。

image

#17414 造成了两次回滚,分别予以验证通过:

📝 Changelog

Language Changelog
🇺🇸 English Fix Input clear icon not align correctly.
🇨🇳 Chinese 修复 Input 清除图标不居中对齐的问题。

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@netlify
Copy link

netlify bot commented Aug 7, 2019

Deploy preview for ant-design ready!

Built with commit f70d270

https://deploy-preview-18151--ant-design.netlify.com

@zombieJ
Copy link
Member

zombieJ commented Aug 8, 2019

备注里把这个 codesandbox 加进来

@afc163
Copy link
Member Author

afc163 commented Aug 8, 2019

备注里把这个 codesandbox 加进来

啥意思?

@buildsize
Copy link

buildsize bot commented Aug 8, 2019

File name Previous Size New Size Change
package-lock.json 819.17 KB 822.52 KB 3.35 KB (0%)

@codecov
Copy link

codecov bot commented Aug 8, 2019

Codecov Report

Merging #18151 into master will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #18151      +/-   ##
==========================================
- Coverage   96.19%   96.15%   -0.04%     
==========================================
  Files         276      276              
  Lines        7524     7524              
  Branches     2051     2051              
==========================================
- Hits         7238     7235       -3     
- Misses        284      287       +3     
  Partials        2        2
Impacted Files Coverage Δ
components/_util/wave.tsx 85.57% <0%> (-2.89%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 96ef478...f70d270. Read the comment docs.

@zombieJ zombieJ merged commit 2cadd5b into master Aug 8, 2019
@delete-merged-branch delete-merged-branch bot deleted the fix-input-clear-icon-style branch August 8, 2019 07:09
@yesmeck yesmeck mentioned this pull request Aug 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants