New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: upload add download icon #18524
Conversation
Deploy preview for ant-design ready! Built with commit ccd01a7 |
语言包只加了中文和英文 |
Codecov Report
@@ Coverage Diff @@
## master #18524 +/- ##
==========================================
- Coverage 96.73% 96.58% -0.16%
==========================================
Files 280 280
Lines 7532 7550 +18
Branches 2095 2105 +10
==========================================
+ Hits 7286 7292 +6
- Misses 244 256 +12
Partials 2 2
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #18524 +/- ##
==========================================
- Coverage 96.73% 96.58% -0.16%
==========================================
Files 280 280
Lines 7532 7550 +18
Branches 2095 2105 +10
==========================================
+ Hits 7286 7292 +6
- Misses 244 256 +12
Partials 2 2
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #18524 +/- ##
==========================================
+ Coverage 96.73% 96.76% +0.03%
==========================================
Files 280 280
Lines 7532 7546 +14
Branches 2095 2060 -35
==========================================
+ Hits 7286 7302 +16
+ Misses 244 242 -2
Partials 2 2
Continue to review full report at Codecov.
|
@afc163 会考虑合并吗?添加了下载 Icon,删除 Icon 改用了 delete(我觉得不是关闭,而是删除所以才改的),Upload 现在定位不只是图片预览,也有上传 xls、pdf 文件用,但是 pdf 默认浏览器预览,所以单加一个按钮,就是对任何格式都可以直接下载(需要后端支持)。 |
feature branch |
终于 ok 了, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
feature branch please
下一步要做啥?不太懂 |
🤔 This is a ...
🔗 Related issue link
💡 Background and solution
📝 Changelog
☑️ Self Check before Merge