Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upload add download icon #18524

Closed
wants to merge 20 commits into from
Closed

feat: upload add download icon #18524

wants to merge 20 commits into from

Conversation

crazyair
Copy link
Member

@crazyair crazyair commented Aug 28, 2019

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English upload add download icon
🇨🇳 Chinese upload 添加下载按钮

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@netlify
Copy link

netlify bot commented Aug 28, 2019

Deploy preview for ant-design ready!

Built with commit ccd01a7

https://deploy-preview-18524--ant-design.netlify.com

@crazyair
Copy link
Member Author

语言包只加了中文和英文

@codecov
Copy link

codecov bot commented Aug 28, 2019

Codecov Report

Merging #18524 into master will decrease coverage by 0.15%.
The diff coverage is 55.55%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #18524      +/-   ##
==========================================
- Coverage   96.73%   96.58%   -0.16%     
==========================================
  Files         280      280              
  Lines        7532     7550      +18     
  Branches     2095     2105      +10     
==========================================
+ Hits         7286     7292       +6     
- Misses        244      256      +12     
  Partials        2        2
Impacted Files Coverage Δ
components/upload/Upload.tsx 92.02% <28.57%> (-3.43%) ⬇️
components/upload/UploadList.tsx 89.89% <65%> (-6.66%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab6dd46...afdf3cb. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Aug 28, 2019

Codecov Report

Merging #18524 into master will decrease coverage by 0.15%.
The diff coverage is 55.55%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #18524      +/-   ##
==========================================
- Coverage   96.73%   96.58%   -0.16%     
==========================================
  Files         280      280              
  Lines        7532     7550      +18     
  Branches     2095     2105      +10     
==========================================
+ Hits         7286     7292       +6     
- Misses        244      256      +12     
  Partials        2        2
Impacted Files Coverage Δ
components/upload/Upload.tsx 92.02% <28.57%> (-3.43%) ⬇️
components/upload/UploadList.tsx 89.89% <65%> (-6.66%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab6dd46...afdf3cb. Read the comment docs.

@codecov
Copy link

codecov bot commented Aug 28, 2019

Codecov Report

Merging #18524 into master will increase coverage by 0.03%.
The diff coverage is 95.65%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #18524      +/-   ##
==========================================
+ Coverage   96.73%   96.76%   +0.03%     
==========================================
  Files         280      280              
  Lines        7532     7546      +14     
  Branches     2095     2060      -35     
==========================================
+ Hits         7286     7302      +16     
+ Misses        244      242       -2     
  Partials        2        2
Impacted Files Coverage Δ
components/upload/Upload.tsx 95.45% <100%> (ø) ⬆️
components/upload/UploadList.tsx 96.03% <95.45%> (-0.52%) ⬇️
components/_util/wave.tsx 88.46% <0%> (+2.88%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab6dd46...ccd01a7. Read the comment docs.

@crazyair
Copy link
Member Author

crazyair commented Aug 29, 2019

@afc163 会考虑合并吗?添加了下载 Icon,删除 Icon 改用了 delete(我觉得不是关闭,而是删除所以才改的),Upload 现在定位不只是图片预览,也有上传 xls、pdf 文件用,但是 pdf 默认浏览器预览,所以单加一个按钮,就是对任何格式都可以直接下载(需要后端支持)。

@crazyair crazyair changed the title upload-add-download feat:upload add download icon Sep 2, 2019
@buildsize
Copy link

buildsize bot commented Sep 3, 2019

File name Previous Size New Size Change
package-lock.json 833.35 KB 834.72 KB 1.37 KB (0%)

@afc163
Copy link
Member

afc163 commented Sep 3, 2019

feature branch

@crazyair crazyair changed the title feat:upload add download icon feat: upload add download icon Sep 3, 2019
@crazyair
Copy link
Member Author

crazyair commented Sep 4, 2019

终于 ok 了,

Copy link
Member

@afc163 afc163 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

feature branch please

components/locale/default.tsx Outdated Show resolved Hide resolved
components/upload/index.en-US.md Outdated Show resolved Hide resolved
components/upload/index.zh-CN.md Outdated Show resolved Hide resolved
@crazyair
Copy link
Member Author

crazyair commented Sep 4, 2019

下一步要做啥?不太懂

@afc163
Copy link
Member

afc163 commented Sep 4, 2019

@crazyair
Copy link
Member Author

crazyair commented Sep 4, 2019

@crazyair crazyair closed this Sep 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants