New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(Anchor): optimize dataNowMockFn, avoid being consumed in advance #18663
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please add tests to make sure this change works as expected?
Deploy preview for ant-design ready! Built with commit da5c01b |
对的,改之。 |
看了下 node 版本是 |
这个测试错误看起来像是 facebook/react#12214 (comment) 命名导出的问题,没发现 node 新的版本对导出有什么限制更新 |
合一下 master, 下午 fix 了 |
Codecov Report
@@ Coverage Diff @@
## master #18663 +/- ##
=======================================
Coverage 96.74% 96.74%
=======================================
Files 281 281
Lines 7551 7551
Branches 2106 2106
=======================================
Hits 7305 7305
Misses 244 244
Partials 2 2 Continue to review full report at Codecov.
|
还是不行 |
我本地试了下是有问题
|
@shaodahong 正好赶上我们发布上线,服务端渲染也报这个错误 |
嗯, |
|
重装一下,rc-menu 的 is mobile 降级发了个 patch |
没啥必要,jest 是 node 端的工具,兼容不同 node 版本很重要。我们是 UI 库,node 环境保证自用就行,测试的是浏览器环境。 |
好的,那看来是没问题了 |
🤔 This is a ...
🔗 Related issue link
#17827
💡 Background and solution
📝 Changelog
☑️ Self Check before Merge