Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: table column width broken by long word #18789

Merged
merged 1 commit into from Sep 12, 2019
Merged

Conversation

afc163
Copy link
Member

@afc163 afc163 commented Sep 12, 2019

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

#13825 (comment)

close #13825 , again

💡 Background and solution

继续补充 #17284

📝 Changelog

Language Changelog
🇺🇸 English same as #17284
🇨🇳 Chinese none

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@netlify
Copy link

netlify bot commented Sep 12, 2019

Deploy preview for ant-design ready!

Built with commit fbce1d6

https://deploy-preview-18789--ant-design.netlify.com

@codecov
Copy link

codecov bot commented Sep 12, 2019

Codecov Report

Merging #18789 into feature will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           feature   #18789      +/-   ##
===========================================
+ Coverage    96.76%   96.79%   +0.03%     
===========================================
  Files          281      281              
  Lines         7562     7562              
  Branches      2067     2067              
===========================================
+ Hits          7317     7320       +3     
+ Misses         243      240       -3     
  Partials         2        2
Impacted Files Coverage Δ
components/_util/wave.tsx 88.46% <0%> (+2.88%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f659d23...fbce1d6. Read the comment docs.

@afc163
Copy link
Member Author

afc163 commented Sep 12, 2019

来个 approve?

@@ -596,6 +596,11 @@
&-cell-ellipsis .@{table-prefix-cls}-column-title {
display: block;
}

&-cell-break-word {
word-wrap: break-word;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overflow-wrap: break-word; ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

一样的,word-wrap 兼容性还好点。

@afc163 afc163 merged commit 632ba44 into feature Sep 12, 2019
@afc163 afc163 deleted the upgrade-rc-table branch September 12, 2019 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants