docs: 3.23.5 changelog #19056

ikobe-zz · 2019-09-29T08:58:32Z

🤔 This is a ...

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language	Changelog
🇺🇸 English	3.23.5 changelog
🇨🇳 Chinese	3.23.5 changelog

☑️ Self Check before Merge

Doc is updated/provided or not needed
Demo is updated/provided or not needed
TypeScript definition is updated/provided or not needed
Changelog is provided or not needed

3.23.5

🐞 修复 Upload 预览图片无法填充满图片框的问题。#18990
🐞 修复 Breadcrumb 不支持 data-* 和 aria-* 的问题。#18941 @sosohime
🐞 修复 TreeSelect removeIcon 和 clearIcon 不工作的问题。#18949 @sosohime
🐞 修复 Tree 组件当 showLine 设置后 switcherIcon 没有正常工作的问题。#18829 @MrHeer
🐞 修复按钮图标在 Button.Group 中的错位问题。#18994
🐞 移除 Select 中无效属性 searchValue 的定义及文档。#19003
🐞 修复 Avatar 文本头像在 ssr 时会闪烁的问题。#19029
TypeScript
- 🐞 修复 Grid 组件的类型定义。#18946 @handycode

🐞 Fix Upload preview image cannot fill the picture card box. #18990
🐞 Fix Breadcrumb not support data-* and aria-* attributes. #18941 @sosohime
🐞 Fix TreeSelect removeIcon and clearIcon not working. #18949 @sosohime
🐞 Fix Tree switcherIcon prop not working when showLine is true. #18829 @MrHeer
🐞 Fix style bug of Button with icon only when in Button.Group. #18994
🐞 Remove Select useless prop searchValue which is a total misunderstanding. #19003
🐞 Fix Avatar string blink when ssr render at first time. #19029
TypeScript
- 🐞 Fix Grid type definition. #18946 @handycode

View rendered CHANGELOG.en-US.md
View rendered CHANGELOG.zh-CN.md

netlify · 2019-09-29T08:58:41Z

Deploy preview for ant-design ready!

Built with commit 82ab624

https://deploy-preview-19056--ant-design.netlify.com

zombieJ · 2019-09-29T09:04:30Z

CHANGELOG.en-US.md

+`2019-09-29`
+
+- 🌟 Breadcrumb support `data-*` and `aria-*` attributes. [#18941](https://github.com/ant-design/ant-design/pull/18941) [@sosohime](https://github.com/sosohime)
+- 💄 Adjust Upload `picture-card` mode picture display style to fill the picture box. [#18990](https://github.com/ant-design/ant-design/pull/18990)


这个当时写的时候就觉得表达很怪异，看看能否表达的更好。效果就是 issue 的截图。

Fix Upload preview image cannot fill the picture card box.

afc163 · 2019-09-29T09:06:40Z

CHANGELOG.en-US.md

+
+`2019-09-29`
+
+- 🌟 Breadcrumb support `data-*` and `aria-*` attributes. [#18941](https://github.com/ant-design/ant-design/pull/18941) [@sosohime](https://github.com/sosohime)


修复 Breadcrumb 不支持 ****** 的问题。

zombieJ · 2019-09-29T09:07:22Z

CHANGELOG.en-US.md

+- 💄 Adjust Upload `picture-card` mode picture display style to fill the picture box. [#18990](https://github.com/ant-design/ant-design/pull/18990)
+- 🐞 Fix TreeSelect `removeIcon` and `clearIcon` not working. [#18949](https://github.com/ant-design/ant-design/issues/18949) [@sosohime](https://github.com/sosohime)
+- 🐞 Fix Tree `switcherIcon` prop not working when `showLine` is true. [#18829](https://github.com/ant-design/ant-design/pull/18829) [@MrHeer](https://github.com/MrHeer)
+- 🐞 Fix icon only Button style bug in Button.Group. [#18994](https://github.com/ant-design/ant-design/pull/18994)


Fix style bug of Button with icon only when in Button.Group.

orzyyyy · 2019-09-29T09:04:51Z

CHANGELOG.zh-CN.md

+- 🐞 移除实际上毫无作用的 Select `searchValue` 属性定义和文档。[#19003](https://github.com/ant-design/ant-design/pull/19003)
+- 🐞 移除 Input 中无用的 `size` 属性。[#19025](https://github.com/ant-design/ant-design/pull/19025) [@ahauzq](https://github.com/ahauzq)
+- 🐞 修复 Avatar 文本头像在 ssr 时会闪烁的问题。[#19029](https://github.com/ant-design/ant-design/pull/19029)
+- 🐞 修复用静态属性替代 class 类型来判断子组件是一个 antd button 的问题。[#19045](https://github.com/ant-design/ant-design/pull/19045)


这个还是提一下适用场景吧，不然都不知道是干嘛的。
改成

调整 Input 中 Button 的静态属性，用于 HOC 中判断子组件类型是否是 antd button

如何？

orzyyyy · 2019-09-29T09:05:11Z

CHANGELOG.zh-CN.md

+- 🐞 修复用静态属性替代 class 类型来判断子组件是一个 antd button 的问题。[#19045](https://github.com/ant-design/ant-design/pull/19045)
+- TypeScript
+  - 🐞 修复 Grid 组件的类型定义。[#18946](https://github.com/ant-design/ant-design/pull/18946) [@handycode](https://github.com/handycode)
+- 📝 更新了几处文档。[#18977](https://github.com/ant-design/ant-design/pull/18977) [@hsuanxyz](https://github.com/hsuanxyz) [#19014](https://github.com/ant-design/ant-design/pull/19014) [@fkysly](https://github.com/fkysly)


文档似乎不用提？

orzyyyy · 2019-09-29T09:07:01Z

CHANGELOG.zh-CN.md

+- 🐞 修复 TreeSelect `removeIcon` 和 `clearIcon` 不工作的问题。[#18949](https://github.com/ant-design/ant-design/issues/18949) [@sosohime](https://github.com/sosohime)
+- 🐞 修复 Tree 组件当 showLine 设置后 `switcherIcon` 没有正常工作的问题。[#18829](https://github.com/ant-design/ant-design/pull/18829) [@MrHeer](https://github.com/MrHeer)
+- 🐞 修复按钮图标在 Button.Group 中的错位问题。[#18994](https://github.com/ant-design/ant-design/pull/18994)
+- 🐞 移除实际上毫无作用的 Select `searchValue` 属性定义和文档。[#19003](https://github.com/ant-design/ant-design/pull/19003)


毫无作用这词总觉得主观色彩太重了，改成

移除 Select 中无效属性 searchValue 的定义及文档

如何？

zombieJ · 2019-09-29T09:07:38Z

CHANGELOG.en-US.md

+- 🐞 Fix TreeSelect `removeIcon` and `clearIcon` not working. [#18949](https://github.com/ant-design/ant-design/issues/18949) [@sosohime](https://github.com/sosohime)
+- 🐞 Fix Tree `switcherIcon` prop not working when `showLine` is true. [#18829](https://github.com/ant-design/ant-design/pull/18829) [@MrHeer](https://github.com/MrHeer)
+- 🐞 Fix icon only Button style bug in Button.Group. [#18994](https://github.com/ant-design/ant-design/pull/18994)
+- 🐞 Remove Select useless prop `searchValue`which is a total misunderstanding. [#19003](https://github.com/ant-design/ant-design/pull/19003)


少了一个空格

zombieJ · 2019-09-29T09:08:14Z

CHANGELOG.zh-CN.md

+- 🌟 Breadcrumb 支持 `data-*` 和 `aria-*` 属性。[#18941](https://github.com/ant-design/ant-design/pull/18941) [@sosohime](https://github.com/sosohime)
+- 💄 调整 Upload `picture-card` 模式下，图片展示样式为填充整个图片框。[#18990](https://github.com/ant-design/ant-design/pull/18990)
+- 🐞 修复 TreeSelect `removeIcon` 和 `clearIcon` 不工作的问题。[#18949](https://github.com/ant-design/ant-design/issues/18949) [@sosohime](https://github.com/sosohime)
+- 🐞 修复 Tree 组件当 showLine 设置后 `switcherIcon` 没有正常工作的问题。[#18829](https://github.com/ant-design/ant-design/pull/18829) [@MrHeer](https://github.com/MrHeer)


chenshuai2144 · 2019-09-29T09:08:40Z

调整 Upload picture-card 模式下，图片展示样式为填充整个图片框。#18990

Upload picture-card 模式下，调整图片展示样式为填充整个图片框。#18990

codecov · 2019-09-29T09:11:24Z

Codecov Report

Merging #19056 into master will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #19056      +/-   ##
==========================================
+ Coverage   97.38%   97.39%   +0.01%     
==========================================
  Files         280      281       +1     
  Lines        7526     7559      +33     
  Branches     2109     2112       +3     
==========================================
+ Hits         7329     7362      +33     
  Misses        196      196              
  Partials        1        1

Impacted Files	Coverage Δ
components/affix/index.tsx	`97.32% <0%> (ø)`	⬆️
components/_util/resizeObserver.tsx	`100% <0%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e07bba9...82ab624. Read the comment docs.

ikobe-zz · 2019-09-29T11:36:26Z

@afc163 @zombieJ @orzyyyy 更新了一波

zombieJ · 2019-09-29T11:40:34Z

CHANGELOG.en-US.md

+- 🐞 Fix Tree `switcherIcon` prop not working when `showLine` is true. [#18829](https://github.com/ant-design/ant-design/pull/18829) [@MrHeer](https://github.com/MrHeer)
+- 🐞 Fix style bug of Button with icon only when in Button.Group. [#18994](https://github.com/ant-design/ant-design/pull/18994)
+- 🐞 Remove Select useless prop `searchValue` which is a total misunderstanding. [#19003](https://github.com/ant-design/ant-design/pull/19003)
+- 🐞 Remove Input useless `size` props. [#19025](https://github.com/ant-design/ant-design/pull/19025) [@ahauzq](https://github.com/ahauzq)


这个是内部的，感觉不用写。去除 size prop 要吓死用户的。

* ✅ increase upload test cov * chore: replace resizeObserver with `rc-resize-observer` (#19057) * replace resizeObserver with rc-resize-observer * fix affix lint * fix es lint * changelog (#19056) * Release 3.23.5

auto-add-label bot added the documentation label Sep 29, 2019

pr-triage bot added the PR: unreviewed label Sep 29, 2019

ikobe-zz force-pushed the release-3.23.5 branch from f386b7b to 0ed65f3 Compare September 29, 2019 09:03

zombieJ reviewed Sep 29, 2019

View reviewed changes

afc163 reviewed Sep 29, 2019

View reviewed changes

zombieJ reviewed Sep 29, 2019

View reviewed changes

orzyyyy reviewed Sep 29, 2019

View reviewed changes

zombieJ reviewed Sep 29, 2019

View reviewed changes

ikobe-zz force-pushed the release-3.23.5 branch from 583ea5d to f07f6f9 Compare September 29, 2019 11:34

ikobe-zz force-pushed the release-3.23.5 branch from f07f6f9 to 57d797d Compare September 29, 2019 11:38

zombieJ reviewed Sep 29, 2019

View reviewed changes

changelog

82ab624

ikobe-zz force-pushed the release-3.23.5 branch from 57d797d to 82ab624 Compare September 29, 2019 11:42

ikobe-zz merged commit ba7ddfa into master Sep 29, 2019

ikobe-zz deleted the release-3.23.5 branch September 29, 2019 12:02

pr-triage bot added PR: merged and removed PR: unreviewed labels Sep 29, 2019

weekly-digest bot mentioned this pull request Oct 6, 2019

Weekly Digest (29 September, 2019 - 6 October, 2019) #19104

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

docs: 3.23.5 changelog #19056

docs: 3.23.5 changelog #19056

ikobe-zz commented Sep 29, 2019 •

edited

netlify bot commented Sep 29, 2019 •

edited

zombieJ Sep 29, 2019

afc163 Sep 29, 2019 •

edited

afc163 Sep 29, 2019

zombieJ Sep 29, 2019

orzyyyy Sep 29, 2019

orzyyyy Sep 29, 2019

orzyyyy Sep 29, 2019

zombieJ Sep 29, 2019

zombieJ Sep 29, 2019

chenshuai2144 commented Sep 29, 2019

codecov bot commented Sep 29, 2019 •

edited

ikobe-zz commented Sep 29, 2019

zombieJ Sep 29, 2019


		`2019-09-29`

		- 🌟 Breadcrumb support `data-` and `aria-` attributes. [#18941](https://github.com/ant-design/ant-design/pull/18941) [@sosohime](https://github.com/sosohime)

docs: 3.23.5 changelog #19056

docs: 3.23.5 changelog #19056

Conversation

ikobe-zz commented Sep 29, 2019 • edited

🤔 This is a ...

🔗 Related issue link

💡 Background and solution

📝 Changelog

☑️ Self Check before Merge

3.23.5

netlify bot commented Sep 29, 2019 • edited

Choose a reason for hiding this comment

afc163 Sep 29, 2019 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

chenshuai2144 commented Sep 29, 2019

codecov bot commented Sep 29, 2019 • edited

Codecov Report

ikobe-zz commented Sep 29, 2019

Choose a reason for hiding this comment

ikobe-zz commented Sep 29, 2019 •

edited

netlify bot commented Sep 29, 2019 •

edited

afc163 Sep 29, 2019 •

edited

codecov bot commented Sep 29, 2019 •

edited