Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Layout): add prop zeroWidthTriggerStyle #19079

Merged
merged 5 commits into from Oct 7, 2019
Merged

feat(Layout): add prop zeroWidthTriggerStyle #19079

merged 5 commits into from Oct 7, 2019

Conversation

orzyyyy
Copy link
Contributor

@orzyyyy orzyyyy commented Oct 2, 2019

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English add prop specialTriggerStyle to controll the style of the special trigger that appears when collapsedWidth is 0.
🇨🇳 Chinese 新增属性 specialTriggerStyle 以控制当 collapsedWidth 为 0 时,出现的特殊 trigger 的样式。

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@pr-triage pr-triage bot added the PR: draft label Oct 2, 2019
Copy link

@tests-checker tests-checker bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add tests to make sure this change works as expected?

@netlify
Copy link

netlify bot commented Oct 2, 2019

Deploy preview for ant-design ready!

Built with commit 2174fc9

https://deploy-preview-19079--ant-design.netlify.com

@orzyyyy
Copy link
Contributor Author

orzyyyy commented Oct 5, 2019

/rebase

1 similar comment
@afc163
Copy link
Member

afc163 commented Oct 6, 2019

/rebase

@orzyyyy orzyyyy marked this pull request as ready for review October 6, 2019 09:13
@codecov
Copy link

codecov bot commented Oct 6, 2019

Codecov Report

Merging #19079 into feature will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           feature   #19079   +/-   ##
========================================
  Coverage    97.76%   97.76%           
========================================
  Files          281      281           
  Lines         7605     7605           
  Branches      2135     2135           
========================================
  Hits          7435     7435           
  Misses         170      170
Impacted Files Coverage Δ
components/layout/Sider.tsx 95.6% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 391aab4...2174fc9. Read the comment docs.

@afc163
Copy link
Member

afc163 commented Oct 6, 2019

zeroWidthTriggerStyle

@afc163 afc163 changed the title feat(Layout): add prop specialTriggerStyle feat(Layout): add prop zeroWidthTriggerStyle Oct 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants