Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add drawerStyle and headerStyle #19109

Merged
merged 1 commit into from Oct 7, 2019
Merged

feat: Add drawerStyle and headerStyle #19109

merged 1 commit into from Oct 7, 2019

Conversation

afc163
Copy link
Member

@afc163 afc163 commented Oct 7, 2019

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

close #18975

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Support drawerStyle and headerStyle for Drawer.
🇨🇳 Chinese Drawer 新增 drawerStyleheaderStyle 属性。

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

View rendered components/drawer/index.en-US.md
View rendered components/drawer/index.zh-CN.md

Copy link

@tests-checker tests-checker bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add tests to make sure this change works as expected?

@netlify
Copy link

netlify bot commented Oct 7, 2019

Deploy preview for ant-design ready!

Built with commit 943d23a

https://deploy-preview-19109--ant-design.netlify.com

@codecov
Copy link

codecov bot commented Oct 7, 2019

Codecov Report

Merging #19109 into feature will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff            @@
##           feature   #19109   +/-   ##
========================================
  Coverage    97.76%   97.76%           
========================================
  Files          281      281           
  Lines         7605     7605           
  Branches      2138     2135    -3     
========================================
  Hits          7435     7435           
  Misses         170      170
Impacted Files Coverage Δ
components/drawer/index.tsx 98.71% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 718a86d...943d23a. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants