Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update message content with a unique key and cancel manually #19967

Merged
merged 1 commit into from Nov 28, 2019

Conversation

Aemple
Copy link
Contributor

@Aemple Aemple commented Nov 27, 2019

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

#18678

💡 Background and solution

close #19950

📝 Changelog

Language Changelog
🇺🇸 English repair update message content with a unique key can‘t cancel manually
🇨🇳 Chinese 修复message组件使用key时无法手动取消的情况

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

View rendered components/message/demo/update.md

Copy link

@tests-checker tests-checker bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add tests to make sure this change works as expected?

@netlify
Copy link

netlify bot commented Nov 27, 2019

Deploy preview for ant-design ready!

Built with commit 22c13f5

https://deploy-preview-19967--ant-design.netlify.com

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 22c13f5:

Sandbox Source
antd reproduction template Configuration

@codecov
Copy link

codecov bot commented Nov 27, 2019

Codecov Report

Merging #19967 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #19967      +/-   ##
==========================================
- Coverage    97.8%    97.8%   -0.01%     
==========================================
  Files         284      284              
  Lines        7707     7706       -1     
  Branches     2169     2155      -14     
==========================================
- Hits         7538     7537       -1     
  Misses        169      169
Impacted Files Coverage Δ
components/message/index.tsx 94.2% <100%> (-0.09%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d82b59...22c13f5. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

message updating with key ,但是不能手动移除了
2 participants