fix: Upload should not showing download icon defaultly #21496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM，v4也同步过去吧。 |
afc163
force-pushed
the
update-show-download
branch
from
224becb
to
f30f3e1
Compare
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
afc163
force-pushed
the
update-show-download
branch
2 times, most recently
from
66af276
to
c1a0d30
Compare
afc163
changed the title
afc163
force-pushed
the
update-show-download
branch
2 times, most recently
from
459441c
to
3774f36
Compare
it should be false
afc163
force-pushed
the
update-show-download
branch
from
3774f36
to
c4faea2
Compare
Codecov Report
@@ Coverage Diff @@
## 3.x-stable #21496 +/- ##
===========================================
Coverage 97.82% 97.82%
===========================================
Files 286 286
Lines 7766 7766
Branches 2192 2192
===========================================
Hits 7597 7597
Misses 169 169
Continue to review full report at Codecov.
|
|
Cherry picked to master b4636ab |
Merged
This was referenced Mar 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it should be false
🤔 This is a ...
🔗 Related issue link
#18664 (comment)
#4351 (comment)
ant-design/ant-design-pro#5606
💡 Background and solution
目前关于如何隐藏下载按钮的反馈很多，#18664 应保持向前兼容，默认不应该展现。
📝 Changelog
☑️ Self Check before Merge