Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: multiple select search input doesn't show normally on Safari #22586

Merged
merged 2 commits into from Mar 25, 2020

Conversation

iicdii
Copy link
Contributor

@iicdii iicdii commented Mar 25, 2020

馃 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

馃敆 Related issue link

This fix #21950

馃挕 Background and solution

Safari's default padding hide input box in multiple selection.
76078774-b01c8f80-5fe6-11ea-9eaa-fc02e7ba49e7

/* user agent style sheet in Safari */
textarea, input[type="range"], input, input:matches([type="password"], [type="search"]) {
  ...
  padding-top: 0.2em;
  padding-right: 0.5em;
  padding-bottom: 0.3em;
  padding-left: 0.5em;
}

/* user agent style sheet in Chrome */
textarea, input[type="range"], input, input:matches([type="password"], [type="search"]) {
  ...
  padding-top: 1px;
  padding-right: 1px;
  padding-bottom: 1px;
  padding-left: 1px;
}

So I add padding: 1px to input to avoid search box is hidden by browser.

馃摑 Changelog

Language Changelog
馃嚭馃嚫 English Fix padding:1px to multiple selection input
馃嚚馃嚦 Chinese

鈽戯笍 Self Check before Merge

鈿狅笍 Please check all items below before review. 鈿狅笍

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@codecov
Copy link

codecov bot commented Mar 25, 2020

Codecov Report

Merging #22586 into 3.x-stable will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           3.x-stable   #22586   +/-   ##
===========================================
  Coverage       97.71%   97.71%           
===========================================
  Files             286      286           
  Lines            7781     7781           
  Branches         2196     2193    -3     
===========================================
  Hits             7603     7603           
  Misses            178      178

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 282c792...4174d36. Read the comment docs.


input {
padding: 1px;
}
Copy link
Member

@afc163 afc163 Mar 25, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

He seems to be Korean, so he cannot speak Chinese.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@afc163 Thank you for the feedback. I moved the style where you mentioned.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants