Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: hidden should higher than noStyle #26020

Merged
merged 2 commits into from Aug 5, 2020
Merged

fix: hidden should higher than noStyle #26020

merged 2 commits into from Aug 5, 2020

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented Aug 4, 2020

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

resolve #26007

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fix Form.Item hidden not work with noStyle.
🇨🇳 Chinese 修复 Form.Item hidden 不能和 noStyle 一同使用的问题。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Aug 4, 2020

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Aug 4, 2020

@codesandbox-ci
Copy link

codesandbox-ci bot commented Aug 4, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 8230569:

Sandbox Source
antd reproduction template Configuration

@github-actions
Copy link
Contributor

github-actions bot commented Aug 4, 2020

Size Change: +7 B (0%)

Total Size: 785 kB

Filename Size Change
./dist/antd-with-locales.min.js 311 kB +3 B (0%)
./dist/antd.min.js 279 kB +4 B (0%)
ℹ️ View Unchanged
Filename Size Change
./dist/antd.compact.min.css 64.8 kB 0 B
./dist/antd.dark.min.css 66 kB 0 B
./dist/antd.min.css 64.8 kB 0 B

compressed-size-action

@codecov
Copy link

codecov bot commented Aug 4, 2020

Codecov Report

Merging #26020 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #26020   +/-   ##
=======================================
  Coverage   99.57%   99.57%           
=======================================
  Files         373      373           
  Lines        7314     7314           
  Branches     1994     2044   +50     
=======================================
  Hits         7283     7283           
  Misses         31       31           
Impacted Files Coverage Δ
components/form/FormItem.tsx 99.22% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5131c24...8230569. Read the comment docs.

@zombieJ zombieJ merged commit c345580 into master Aug 5, 2020
@zombieJ zombieJ deleted the fix-hidden branch August 5, 2020 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Form.Item specifies noStyle and hidden at the same time, hidden does not take effect
2 participants