Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: menu position in dark rtl #26032

Merged
merged 1 commit into from Aug 5, 2020
Merged

fix: menu position in dark rtl #26032

merged 1 commit into from Aug 5, 2020

Conversation

xrkffgg
Copy link
Member

@xrkffgg xrkffgg commented Aug 5, 2020

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

View
Before image
After image

📝 Changelog

Language Changelog
🇺🇸 English Fix the position of the horizontal Menu in dark theme and RTL mode.
🇨🇳 Chinese 修复水平方向 Menu 在暗黑主题 RTL 模式下的位置。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Aug 5, 2020

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Aug 5, 2020

@codesandbox-ci
Copy link

codesandbox-ci bot commented Aug 5, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit c53642d:

Sandbox Source
antd reproduction template Configuration

@codecov
Copy link

codecov bot commented Aug 5, 2020

Codecov Report

Merging #26032 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #26032   +/-   ##
=======================================
  Coverage   99.57%   99.57%           
=======================================
  Files         373      373           
  Lines        7314     7314           
  Branches     2035     2035           
=======================================
  Hits         7283     7283           
  Misses         31       31           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aacdc2e...c53642d. Read the comment docs.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 5, 2020

Size Change: -4 B (0%)

Total Size: 785 kB

Filename Size Change
./dist/antd.dark.min.css 66 kB -4 B (0%)
ℹ️ View Unchanged
Filename Size Change
./dist/antd-with-locales.min.js 311 kB 0 B
./dist/antd.compact.min.css 64.8 kB 0 B
./dist/antd.min.css 64.8 kB 0 B
./dist/antd.min.js 279 kB 0 B

compressed-size-action

@afc163 afc163 merged commit a6f787e into master Aug 5, 2020
@afc163 afc163 deleted the fix-menu-rtl branch August 5, 2020 08:50
sorahn pushed a commit to sorahn/ant-design that referenced this pull request Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants