Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(table): not crash with raw data #26041

Closed
wants to merge 1 commit into from

Conversation

congjiujiu
Copy link

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

resolve #26039

💡 Background and solution

page will crash when pass non object array to datasource of table

solution: replace in operator in useSelection hook

📝 Changelog

Language Changelog
🇺🇸 English fix crashes when table dataSorce is not object array
🇨🇳 Chinese 修复 Table 组件在传入非 object 数组时引起的页面崩溃

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Aug 5, 2020

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Aug 5, 2020

@afc163
Copy link
Member

afc163 commented Aug 5, 2020

see #26042

@congjiujiu
Copy link
Author

@afc163 awesome

@congjiujiu congjiujiu closed this Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Table] page crash when dataSource is not an object[]
3 participants