fix: Arabic locale #26094
Merged
fix: Arabic locale #26094
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All Arabic strings in this file flipped the order of the words in the sentence, for example if
${label} = كلمة السر
The old message will be
كلمة السر يرجى إدخال
But the correct message is
يرجى إدخال كلمة السر
|
|
|
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 9f71f94:
|
Codecov Report
@@ Coverage Diff @@
## master #26094 +/- ##
=======================================
Coverage 99.56% 99.56%
=======================================
Files 373 373
Lines 7315 7315
Branches 1994 1994
=======================================
Hits 7283 7283
Misses 32 32
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
💡 Background and solution
All Arabic strings in this file flipped the order of the words in the sentence, for example, if
${label} = كلمة السر
The old message will be
كلمة السر يرجى إدخال
But the correct message is
يرجى إدخال كلمة السر
📝 Changelog
☑️ Self Check before Merge