chore: 🆙 upgrade react 17 #27268

hengkx · 2020-10-21T01:52:41Z

🤔 This is a ...

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language	Changelog
🇺🇸 English	Support React 17.
🇨🇳 Chinese	支持 React 17。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

Doc is updated/provided or not needed
Demo is updated/provided or not needed
TypeScript definition is updated/provided or not needed
Changelog is provided or not needed

ant-design-bot · 2020-10-21T01:56:05Z

ant-design-bot · 2020-10-21T01:56:32Z

hengkx · 2020-10-21T02:06:01Z

@yoyo837 你怎么改图标的

codesandbox-ci · 2020-10-21T02:08:08Z

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 5d15683:

Sandbox	Source
antd reproduction template	Configuration

hengkx · 2020-10-21T02:10:45Z

Block by enzymejs/enzyme#2429

github-actions · 2020-10-21T02:10:48Z

Size Change: 0 B

Total Size: 790 kB

ℹ️ View Unchanged

Filename	Size	Change
`./dist/antd-with-locales.min.js`	313 kB	0 B
`./dist/antd.compact.min.css`	66.6 kB	0 B
`./dist/antd.dark.min.css`	67.9 kB	0 B
`./dist/antd.min.css`	66.7 kB	0 B
`./dist/antd.min.js`	275 kB	0 B

_{compressed-size-action}

yoyo837 · 2020-10-21T02:11:31Z

@yoyo837 你怎么改图标的

从别处复制的，输入法怎么打还不知道。😂

afc163 · 2020-10-21T02:29:07Z

#26136

afc163 · 2020-11-04T07:27:14Z

/rebase

afc163 · 2020-11-17T03:12:58Z

/rebase

afc163 · 2020-11-20T05:55:02Z

/rebase

afc163 · 2020-11-25T07:42:09Z

/rebase

afc163 · 2020-11-30T08:58:18Z

/rebase

afc163 · 2020-12-01T04:13:00Z

bisheng 里还有 react 16 的依赖，导致网站构建失败
react 16 相关的 test 要加一下

codecov · 2020-12-01T04:23:05Z

Codecov Report

Merging #27268 (5d15683) into master (dda1f2b) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master    #27268   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          393       393           
  Lines         7373      7373           
  Branches      2112      2112           
=========================================
  Hits          7373      7373

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dda1f2b...5d15683. Read the comment docs.

afc163 · 2020-12-01T04:24:04Z

/rebase

yoyo837 · 2020-12-01T10:32:22Z

enzyme 支持后再更换吗？

afc163 · 2020-12-01T10:40:10Z

对。

* fix: update CarouselRef goTo args (ant-design#28090) * chore: 🆙 upgrade react 17 (ant-design#27268) ant-design#26136 * fix BUNDLESIZE_GITHUB_TOKEN * docs: supplement Form.List errors (ant-design#28117) * docs: set image preview false in placeholder demo (ant-design#28140) * docs(📖): update v4 migration about less variables change close ant-design#28141 * test: skip List loading demo (ant-design#28133) * fix: TextArea showCount style while using with Form (ant-design#28130) * chore: optimize useModal performance - Do not trigger rerender of parent component (ant-design#28122) * fix: Add type of initialValue prop to Form.List (ant-design#28153) * fix: Add type of initialValue prop to Form.List * Update index.zh-CN.md * Update index.en-US.md * fix(Tree): fix tree drop indicator default direction (ant-design#28150) Co-authored-by: Jarret Moses <jarret.moses@gmail.com> Co-authored-by: Tom Xu <ycxzhkx@gmail.com> Co-authored-by: afc163 <afc163@gmail.com> Co-authored-by: Liming Jin <jinliming2@gmail.com> Co-authored-by: stygian-desolator <73412177+stygian-desolator@users.noreply.github.com> Co-authored-by: 骗你是小猫咪 <darryshaw@gmail.com> Co-authored-by: einq7 <50612752+AlanCutFlim@users.noreply.github.com> Co-authored-by: Elaina Cherudim <shr9192@gmail.com> Co-authored-by: Debiancc <never.be.evil.debian@gmail.com> Co-authored-by: Jingsong Gao <kingsongao1221@gmail.com>

ycjcl868 · 2020-12-06T04:10:21Z

tests/setup.js

-const Adapter = require('enzyme-adapter-react-16');
+const Adapter =
+  process.env.REACT === '16'
+    ? require('enzyme-adapter-react-16') // eslint-disable-line import/no-extraneous-dependencies,import/no-unresolved


enzyme-adapter-react-16 依赖还是需要装

有的，在 ci 里装了。

pr-triage bot added the PR: unreviewed label Oct 21, 2020

yoyo837 changed the title ~~chore: 🆙 upgrade react 17~~ chore: 🆙 upgrade react 17 Oct 21, 2020

hengkx added the PR: draft label Oct 21, 2020

afc163 force-pushed the react17 branch from fc8886c to 142b549 Compare October 21, 2020 17:39

pr-triage bot removed the PR: draft label Oct 21, 2020

github-actions bot force-pushed the react17 branch from 142b549 to 663ea5b Compare November 4, 2020 07:28

github-actions bot force-pushed the react17 branch from 663ea5b to 2d0ecf6 Compare November 17, 2020 03:14

github-actions bot force-pushed the react17 branch from 2d0ecf6 to cf56018 Compare November 20, 2020 05:56

github-actions bot force-pushed the react17 branch from cf56018 to a34ee42 Compare November 25, 2020 07:43

github-actions bot force-pushed the react17 branch from a34ee42 to 473f862 Compare November 30, 2020 08:59

afc163 force-pushed the react17 branch 3 times, most recently from 65a4c55 to daa9560 Compare December 1, 2020 04:12

github-actions bot force-pushed the react17 branch from daa9560 to afe4b63 Compare December 1, 2020 04:25

upgrade bisheng

f0ff5ba

afc163 force-pushed the react17 branch from afe4b63 to f0ff5ba Compare December 1, 2020 07:09

bisheng@2.0.0

7579630

afc163 mentioned this pull request Dec 1, 2020

support React 17 benjycui/bisheng#230

Merged

afc163 added 2 commits December 1, 2020 15:52

remove travis

7b54be7

react 16 test

ce60851

afc163 force-pushed the react17 branch from 7977eb8 to ce60851 Compare December 1, 2020 08:03

afc163 added 12 commits December 1, 2020 16:08

fix shell

ae2d45e

fix job env

fcc6b6e

fix job env

d0b7a7a

fix install

a5a0a23

fix shell permission

d0e12b8

fix react 16 ci

74515aa

fix react 16 ci

6dc8014

fix react 16 ci

aacc044

more test for react 16

ef111dc

update action name

3d92f78

fix test name

53d14f8

fix test name

5d15683

afc163 merged commit 32a9ba5 into master Dec 1, 2020

afc163 deleted the react17 branch December 1, 2020 10:28

pr-triage bot added PR: merged and removed PR: unreviewed labels Dec 1, 2020

marianayap mentioned this pull request Dec 3, 2020

Fix Modal Closable #28187

Closed

ycjcl868 reviewed Dec 6, 2020

View reviewed changes

pr-triage bot added PR: unreviewed and removed PR: merged labels Dec 6, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: 🆙 upgrade react 17 #27268

chore: 🆙 upgrade react 17 #27268

hengkx commented Oct 21, 2020 •

edited by afc163

ant-design-bot commented Oct 21, 2020 •

edited

ant-design-bot commented Oct 21, 2020 •

edited

hengkx commented Oct 21, 2020

codesandbox-ci bot commented Oct 21, 2020 •

edited

hengkx commented Oct 21, 2020 •

edited by yoyo837

github-actions bot commented Oct 21, 2020 •

edited

yoyo837 commented Oct 21, 2020

afc163 commented Oct 21, 2020

afc163 commented Nov 4, 2020

afc163 commented Nov 17, 2020

afc163 commented Nov 20, 2020

afc163 commented Nov 25, 2020

afc163 commented Nov 30, 2020

afc163 commented Dec 1, 2020 •

edited

codecov bot commented Dec 1, 2020 •

edited

afc163 commented Dec 1, 2020

yoyo837 commented Dec 1, 2020

afc163 commented Dec 1, 2020

ycjcl868 Dec 6, 2020

afc163 Dec 6, 2020

chore: 🆙 upgrade react 17 #27268

chore: 🆙 upgrade react 17 #27268

Conversation

hengkx commented Oct 21, 2020 • edited by afc163

🤔 This is a ...

🔗 Related issue link

💡 Background and solution

📝 Changelog

☑️ Self Check before Merge

ant-design-bot commented Oct 21, 2020 • edited

ant-design-bot commented Oct 21, 2020 • edited

hengkx commented Oct 21, 2020

codesandbox-ci bot commented Oct 21, 2020 • edited

hengkx commented Oct 21, 2020 • edited by yoyo837

github-actions bot commented Oct 21, 2020 • edited

yoyo837 commented Oct 21, 2020

afc163 commented Oct 21, 2020

afc163 commented Nov 4, 2020

afc163 commented Nov 17, 2020

afc163 commented Nov 20, 2020

afc163 commented Nov 25, 2020

afc163 commented Nov 30, 2020

afc163 commented Dec 1, 2020 • edited

codecov bot commented Dec 1, 2020 • edited

Codecov Report

afc163 commented Dec 1, 2020

yoyo837 commented Dec 1, 2020

afc163 commented Dec 1, 2020

ycjcl868 Dec 6, 2020

Choose a reason for hiding this comment

afc163 Dec 6, 2020

Choose a reason for hiding this comment

hengkx commented Oct 21, 2020 •

edited by afc163

ant-design-bot commented Oct 21, 2020 •

edited

ant-design-bot commented Oct 21, 2020 •

edited

codesandbox-ci bot commented Oct 21, 2020 •

edited

hengkx commented Oct 21, 2020 •

edited by yoyo837

github-actions bot commented Oct 21, 2020 •

edited

afc163 commented Dec 1, 2020 •

edited

codecov bot commented Dec 1, 2020 •

edited