Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update Tabs api #27410

Merged
merged 5 commits into from Oct 27, 2020
Merged

docs: update Tabs api #27410

merged 5 commits into from Oct 27, 2020

Conversation

jesse3mh9a
Copy link
Contributor

@jesse3mh9a jesse3mh9a commented Oct 27, 2020

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English docs: 4.6.0 changelog #26342, #25138
🇨🇳 Chinese

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Oct 27, 2020

@codesandbox-ci
Copy link

codesandbox-ci bot commented Oct 27, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 7b2311e:

Sandbox Source
antd reproduction template Configuration

@codecov
Copy link

codecov bot commented Oct 27, 2020

Codecov Report

Merging #27410 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master    #27410   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          389       389           
  Lines         7383      7383           
  Branches      2076      2079    +3     
=========================================
  Hits          7383      7383           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2636aac...45713ea. Read the comment docs.

@@ -34,7 +34,7 @@ Ant Design 依次提供了三级选项卡,分别用于不同的场景。
| keyboard | 开启键盘切换功能 | boolean | true | | |
| renderTabBar | 替换 TabBar,用于二次封装标签头 | (props: DefaultTabBarProps, DefaultTabBar: React.ComponentClass) => React.ReactElement | - | | |
| size | 大小,提供 `large` `default` 和 `small` 三种大小 | string | `default` | | |
| tabBarExtraContent | tab bar 上额外的元素 | ReactNode \| {left?: ReactNode, right?: ReactNode} | - | | |
| tabBarExtraContent | tab bar 上额外的元素 | ReactNode \| {left?: ReactNode, right?: ReactNode} | - | 4.6.0 | |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

版本后面那个 可以删了

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

好像发现, 之前animated (zh-CN) 书写上有点问题, 在这里我也改下

| --- | --- | --- | --- | --- |
| activeKey | 当前激活 tab 面板的 key | string | - | |
| addIcon | 自定义添加按钮 | ReactNode | - | 4.4.0 |
| animated | 是否使用动画切换 Tabs, 仅生效于 \`tabPosition="top" | boolean \| { inkBar: boolean, tabPane: boolean } | `{ inkBar: true, tabPane: false }` | |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
| animated | 是否使用动画切换 Tabs, 仅生效于 \`tabPosition="top" | boolean \| { inkBar: boolean, tabPane: boolean } | `{ inkBar: true, tabPane: false }` | |
| animated | 是否使用动画切换 Tabs, 仅生效于 \`tabPosition="top" | boolean \| { inkBar: boolean, tabPane: boolean } | { inkBar: true, tabPane: false } | |

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@xrkffgg xrkffgg changed the title docs: update api docs: update Tabs api Oct 27, 2020
@xrkffgg xrkffgg merged commit abb7245 into ant-design:master Oct 27, 2020
@jesse3mh9a
Copy link
Contributor Author

jesse3mh9a commented Oct 27, 2020

@xrkffgg 刚有个地方没注意!
tabBarExtraContent 只是4.6.0加了一个type, 之前版本 只支持typeReactNode .
这里要怎么描述呢?

@xrkffgg
Copy link
Member

xrkffgg commented Oct 28, 2020

-- 4.6.0
++ object: 4.6.0 

再来个 PR

@xrkffgg xrkffgg mentioned this pull request Oct 28, 2020
19 tasks
07akioni pushed a commit that referenced this pull request Nov 7, 2020
* docs: update api

* Update index.zh-CN.md

* fix

* fix

* suggestion
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants