Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: multiple Select disabled background in dark #29242

Merged
merged 1 commit into from Feb 5, 2021
Merged

fix: multiple Select disabled background in dark #29242

merged 1 commit into from Feb 5, 2021

Conversation

xrkffgg
Copy link
Member

@xrkffgg xrkffgg commented Feb 5, 2021

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

image

ref:

📝 Changelog

Language Changelog
🇺🇸 English Fix problem that the background color is abnormal when multiple Select is disabled in dark.
🇨🇳 Chinese 修复多选 Select 暗黑模式下禁用背景颜色异常的问题。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Feb 5, 2021

@codecov
Copy link

codecov bot commented Feb 5, 2021

Codecov Report

Merging #29242 (6b69cae) into master (b5d7670) will increase coverage by 0.09%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #29242      +/-   ##
===========================================
+ Coverage   99.90%   100.00%   +0.09%     
===========================================
  Files         394       394              
  Lines        7477      7477              
  Branches     2143      2143              
===========================================
+ Hits         7470      7477       +7     
+ Misses          7         0       -7     
Impacted Files Coverage Δ
components/carousel/index.tsx 100.00% <0.00%> (+17.50%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b5d7670...6b69cae. Read the comment docs.

@codesandbox-ci
Copy link

codesandbox-ci bot commented Feb 5, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 6b69cae:

Sandbox Source
antd reproduction template Configuration

@github-actions
Copy link
Contributor

github-actions bot commented Feb 5, 2021

Size Change: +26 B (0%)

Total Size: 835 kB

Filename Size Change
./dist/antd.compact.min.css 67.1 kB +6 B (0%)
./dist/antd.dark.min.css 68.4 kB +12 B (0%)
./dist/antd.min.css 67.1 kB +8 B (0%)
ℹ️ View Unchanged
Filename Size Change
./dist/antd-with-locales.min.js 336 kB 0 B
./dist/antd.min.js 296 kB 0 B

compressed-size-action

@xrkffgg xrkffgg merged commit cb2fc79 into master Feb 5, 2021
@xrkffgg xrkffgg deleted the k-dark branch February 5, 2021 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants