Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: fix Drawer extra using Radio.Group #38385

Merged
merged 4 commits into from Nov 4, 2022
Merged

Conversation

afc163
Copy link
Member

@afc163 afc163 commented Nov 4, 2022

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

close #38297

💡 Background and solution

@zombieJ 这行代码在 #36672 加上的,不确定去掉会有啥问题。

📝 Changelog

Language Changelog
🇺🇸 English Fix Radio.Group style problem using in Drawer extra.
🇨🇳 Chinese 修复在 Drawer extra 中使用 Radio.Group 的样式问题。

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@github-actions
Copy link
Contributor

github-actions bot commented Nov 4, 2022

@github-actions
Copy link
Contributor

github-actions bot commented Nov 4, 2022

Size Change: -3 B (0%)

Total Size: 963 kB

Filename Size Change
./dist/antd.dark.min.css 68.9 kB -1 B (0%)
./dist/antd.min.css 67.6 kB -1 B (0%)
./dist/antd.variable.min.css 68.2 kB -1 B (0%)
ℹ️ View Unchanged
Filename Size
./dist/antd-with-locales.min.js 374 kB
./dist/antd.compact.min.css 67.6 kB
./dist/antd.min.js 316 kB

compressed-size-action

@codecov
Copy link

codecov bot commented Nov 4, 2022

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (01cd7da) compared to base (038c9d0).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff            @@
##            master    #38385   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          446       446           
  Lines         8297      8297           
  Branches      2521      2521           
=========================================
  Hits          8297      8297           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@zombieJ zombieJ merged commit c6762d9 into master Nov 4, 2022
@zombieJ zombieJ deleted the style/drawer-extra branch November 4, 2022 15:00
Copy link
Member

@PeachScript PeachScript left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@@ -114,7 +114,7 @@ const App: React.FC = () => {
},
];

const handleResize =
const handleResize: Function =
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个签名好像没有意义?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

microsoft/TypeScript#20007 (comment)
好像 Function 严格意义上代表的是不能被调用的函数

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

从4.22开始Drawer中给extra设置Radio会出现样式错乱
5 participants