fix(table): fix Table aria-label contains [object Object]
#38389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
19 tasks
Codecov ReportBase: 100.00% // Head: 100.00% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #38389 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 446 446
Lines 8295 8304 +9
Branches 2520 2523 +3
=========================================
+ Hits 8295 8304 +9
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
yoyo837
reviewed
Nov 4, 2022
| title: ColumnTitle<RecordType>, | ||
| props: ColumnTitleProps<RecordType>, | ||
| ) { | ||
| const res = renderColumnTitle(title, props); |
There was a problem hiding this comment.
如果直接改 renderColumnTitle 会有啥影响不
There was a problem hiding this comment.
直接改容易出问题，目前其实就是aria-label和title当中需要纯字符串类型的值，其他场景一般都是可以是ReactNode或其他合法的类型。
afc163
reviewed
Nov 4, 2022
afc163
reviewed
Nov 4, 2022
Co-authored-by: afc163 <afc163@gmail.com>
afc163
approved these changes
Nov 5, 2022
elevensky
pushed a commit
to elevensky/ant-design
that referenced
this pull request
Nov 12, 2022
…sign#38389) * fix: columns title render not as expected * feat: code optimize * feat: update test case * feat: update test case * feat: code optimize * Update components/table/__tests__/Table.test.tsx Co-authored-by: afc163 <afc163@gmail.com> * feat: update aria-label * feat: update test case * feat: update snapshots * feat: update snapshots Co-authored-by: tangwenhui <tangwenhui@rd.netease.com> Co-authored-by: afc163 <afc163@gmail.com>
elevensky
pushed a commit
to elevensky/ant-design
that referenced
this pull request
Nov 22, 2022
…sign#38389) * fix: columns title render not as expected * feat: code optimize * feat: update test case * feat: update test case * feat: code optimize * Update components/table/__tests__/Table.test.tsx Co-authored-by: afc163 <afc163@gmail.com> * feat: update aria-label * feat: update test case * feat: update snapshots * feat: update snapshots Co-authored-by: tangwenhui <tangwenhui@rd.netease.com> Co-authored-by: afc163 <afc163@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
aria-labelis [object Object] #38155💡 Background and solution
aria-label should be use the first text content in element when column title is ReactElement in table
📝 Changelog
aria-labelcontains[object Object].aria-label出现[object Object]的问题。☑️ Self-Check before Merge