Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Pagination simple should support showTotal #38399

Merged
merged 2 commits into from Nov 6, 2022

Conversation

afc163
Copy link
Member

@afc163 afc163 commented Nov 5, 2022

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

close #37140

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fix Pagination simple mode should support showTotal property.
🇨🇳 Chinese 修复 Pagination showTotal 属性在 simple 模式下不生效的问题。

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@github-actions
Copy link
Contributor

github-actions bot commented Nov 5, 2022

@github-actions
Copy link
Contributor

github-actions bot commented Nov 5, 2022

Size Change: -6 B (0%)

Total Size: 963 kB

Filename Size Change
./dist/antd-with-locales.min.js 374 kB -13 B (0%)
./dist/antd.min.js 316 kB +7 B (0%)
ℹ️ View Unchanged
Filename Size
./dist/antd.compact.min.css 67.6 kB
./dist/antd.dark.min.css 68.9 kB
./dist/antd.min.css 67.6 kB
./dist/antd.variable.min.css 68.2 kB

compressed-size-action

@codecov
Copy link

codecov bot commented Nov 5, 2022

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (14e2f09) compared to base (2eb9740).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff            @@
##            master    #38399   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          446       446           
  Lines         8304      8304           
  Branches      2523      2523           
=========================================
  Hits          8304      8304           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@afc163 afc163 merged commit b154c9c into master Nov 6, 2022
@afc163 afc163 deleted the chore/upgrade-rc-pagination branch November 6, 2022 07:58
elevensky pushed a commit to elevensky/ant-design that referenced this pull request Nov 12, 2022
* fix: Pagination simple should support showTotal

* test: add test case
elevensky pushed a commit to elevensky/ant-design that referenced this pull request Nov 22, 2022
* fix: Pagination simple should support showTotal

* test: add test case
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pagination的simple属性会把showTotal的设置无效掉
2 participants