Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(Tree): solve circular import #38421

Merged
merged 1 commit into from Nov 7, 2022

Conversation

KotoriK
Copy link
Contributor

@KotoriK KotoriK commented Nov 7, 2022

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

目前Tree与DirectoryTree存在互相导入的情况,会影响tree shake。
这个PR把原本在Tree.tsx执行的导出修改逻辑移动到了index.ts,在保留现有的组件引入行为的同时,解决这个问题。

📝 Changelog

Language Changelog
🇺🇸 English solve circular import in 'Tree'
🇨🇳 Chinese 去除'树'组件中的循环导入

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@github-actions
Copy link
Contributor

github-actions bot commented Nov 7, 2022

@afc163 afc163 merged commit 39f907a into ant-design:master Nov 7, 2022
elevensky pushed a commit to elevensky/ant-design that referenced this pull request Nov 12, 2022
elevensky pushed a commit to elevensky/ant-design that referenced this pull request Nov 22, 2022
@KotoriK KotoriK deleted the refactor-tree branch August 17, 2023 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants