Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: List key #38431

Merged
merged 5 commits into from Nov 9, 2022
Merged

fix: List key #38431

merged 5 commits into from Nov 9, 2022

Conversation

crazyair
Copy link
Member

@crazyair crazyair commented Nov 8, 2022

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

fix #38425

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English List key
🇨🇳 Chinese List key

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@github-actions
Copy link
Contributor

github-actions bot commented Nov 8, 2022

@github-actions
Copy link
Contributor

github-actions bot commented Nov 8, 2022

Size Change: -29 B (0%)

Total Size: 963 kB

Filename Size Change
./dist/antd-with-locales.min.js 374 kB -26 B (0%)
./dist/antd.min.js 317 kB -3 B (0%)
ℹ️ View Unchanged
Filename Size
./dist/antd.compact.min.css 67.7 kB
./dist/antd.dark.min.css 69 kB
./dist/antd.min.css 67.6 kB
./dist/antd.variable.min.css 68.3 kB

compressed-size-action

@codecov
Copy link

codecov bot commented Nov 8, 2022

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (7467524) compared to base (311a6e9).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff            @@
##            master    #38431   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          447       447           
  Lines         8313      8314    +1     
  Branches      2529      2531    +2     
=========================================
+ Hits          8313      8314    +1     
Impacted Files Coverage Δ
components/list/index.tsx 100.00% <100.00%> (ø)
components/_util/getRenderPropValue.ts 100.00% <0.00%> (ø)
components/input/hooks/useRemovePasswordTimeout.ts 100.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@afc163
Copy link
Member

afc163 commented Nov 8, 2022

问题是啥

@crazyair
Copy link
Member Author

crazyair commented Nov 8, 2022

问题是啥

#38425 因为没有 react key,react 认为是一个元素,所以导致了此问题

@zombieJ zombieJ merged commit b0598e0 into master Nov 9, 2022
@zombieJ zombieJ deleted the fix-text branch November 9, 2022 15:13
elevensky pushed a commit to elevensky/ant-design that referenced this pull request Nov 22, 2022
* fix: 修复 key

* feat: remove old key

* feat: test

* feat: test

* feat: test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Text 组件异常打开问题
3 participants