Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: incorrect warning #38446

Merged
merged 1 commit into from Nov 9, 2022
Merged

fix: incorrect warning #38446

merged 1 commit into from Nov 9, 2022

Conversation

li-jia-nan
Copy link
Member

@li-jia-nan li-jia-nan commented Nov 8, 2022

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English fix: incorrect warning
🇨🇳 Chinese 修复异常警告

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@github-actions
Copy link
Contributor

github-actions bot commented Nov 8, 2022

@li-jia-nan li-jia-nan requested review from hengkx and afc163 and removed request for hengkx November 8, 2022 16:04
@codecov
Copy link

codecov bot commented Nov 8, 2022

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (546f1df) compared to base (d5b16f3).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff            @@
##            master    #38446   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          447       447           
  Lines         8311      8313    +2     
  Branches      2528      2529    +1     
=========================================
+ Hits          8311      8313    +2     
Impacted Files Coverage Δ
components/dropdown/dropdown-button.tsx 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@afc163 afc163 merged commit fe9ac7b into ant-design:master Nov 9, 2022
@li-jia-nan li-jia-nan deleted the fix branch November 9, 2022 01:55
@li-jia-nan
Copy link
Member Author

这个测试用例还有点问题,最后一个case应该是 expect(errSpy).not.toHaveBeenCalled(); 才对

但是不知道为啥跑过了,应该没跑过才对,我再看一下这个

elevensky pushed a commit to elevensky/ant-design that referenced this pull request Nov 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

antd 4.24.1 的版本里 Dropdown.Button 出现了错误的警告
2 participants