Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: fix Menu submenu margin #38714

Merged
merged 1 commit into from Nov 18, 2022
Merged

Conversation

JarvisArt
Copy link
Contributor

@JarvisArt JarvisArt commented Nov 18, 2022

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fix Menu SubMenu margin style.
🇨🇳 Chinese 修复 Menu SubMenu 间距问题。

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@github-actions
Copy link
Contributor

github-actions bot commented Nov 18, 2022

@afc163
Copy link
Member

afc163 commented Nov 18, 2022

有啥问题,描述一下?

@JarvisArt
Copy link
Contributor Author

paddingBottom: 0.02,这个样式是为了修复v4中submenu的8px,而v5的margin为4px,所以不需要了
menu 例子看了一遍,submenu margin都正常了

image

image

@afc163
Copy link
Member

afc163 commented Nov 18, 2022

当时也不知道为啥这个能修复,能去掉就太好了。

@afc163 afc163 changed the title fix: submenu margin chore: remove magic number in Menu margin Nov 18, 2022
@afc163
Copy link
Member

afc163 commented Nov 18, 2022

https://app.argos-ci.com/ant-design/ant-design/builds/2891 看看 diff 是不是预期的。

@afc163 afc163 changed the title chore: remove magic number in Menu margin fix: fix Menu margin style Nov 18, 2022
@codecov
Copy link

codecov bot commented Nov 18, 2022

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (83ac65f) compared to base (a552a5e).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff            @@
##            master    #38714   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          544       544           
  Lines         9370      9368    -2     
  Branches      2650      2650           
=========================================
- Hits          9370      9368    -2     
Impacted Files Coverage Δ
components/menu/style/vertical.tsx 100.00% <ø> (ø)
components/form/FormItem/index.tsx 100.00% <100.00%> (ø)
components/steps/index.tsx 100.00% <100.00%> (ø)
components/slider/index.tsx 100.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@afc163 afc163 changed the title fix: fix Menu margin style style: fix Menu submenu margin Nov 18, 2022
@afc163
Copy link
Member

afc163 commented Nov 18, 2022

看了一下是对的。

@JarvisArt
Copy link
Contributor Author

menu 还存在不少问题,展开submenu会抖动、submenu

看了一下是对的。

是的

@afc163
Copy link
Member

afc163 commented Nov 18, 2022

menu 还存在不少问题,展开submenu会抖动、submenu

一个个修!

@afc163 afc163 merged commit 30fb068 into ant-design:master Nov 18, 2022
This was referenced Nov 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants