Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(menu): menu horizontal border bottom when dark #38741

Merged

Conversation

LuciNyan
Copy link
Contributor

@LuciNyan LuciNyan commented Nov 19, 2022

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

Closes: #38734

💡 Background and solution

Set the border-bottom of menu-horizontal to 0 in the dark mode in the same way as antd@4.X.

📝 Changelog

Language Changelog
🇺🇸 English Fix Menu 1px higher when theme="dark".
🇨🇳 Chinese 修复 Menu 深色 theme 下高度多了 1px 的问题。

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@github-actions
Copy link
Contributor

github-actions bot commented Nov 19, 2022

@LuciNyan LuciNyan marked this pull request as ready for review November 19, 2022 12:02
? {
borderBottom: 0,
}
: {}),
Copy link
Member

@afc163 afc163 Nov 19, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这不是应该放暗色算法里?@zombieJ

@codecov
Copy link

codecov bot commented Nov 19, 2022

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (54ffc9b) compared to base (919f7f9).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff            @@
##            master    #38741   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          544       544           
  Lines         9368      9352   -16     
  Branches      2650      2651    +1     
=========================================
- Hits          9368      9352   -16     
Impacted Files Coverage Δ
components/menu/style/theme.tsx 100.00% <100.00%> (ø)
components/menu/index.tsx 100.00% <0.00%> (ø)
components/affix/index.tsx 100.00% <0.00%> (ø)
components/input/index.tsx 100.00% <0.00%> (ø)
components/radio/index.tsx 100.00% <0.00%> (ø)
components/switch/index.tsx 100.00% <0.00%> (ø)
components/button/button.tsx 100.00% <0.00%> (ø)
components/upload/Upload.tsx 100.00% <0.00%> (ø)
components/checkbox/index.tsx 100.00% <0.00%> (ø)
components/mentions/index.tsx 100.00% <0.00%> (ø)
... and 2 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@afc163 afc163 added the 5.x label Nov 19, 2022
@afc163 afc163 merged commit 68b88d9 into ant-design:master Nov 21, 2022
This was referenced Nov 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Menu height in Header
2 participants