Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: export style method #38786

Closed
wants to merge 1 commit into from
Closed

feat: export style method #38786

wants to merge 1 commit into from

Conversation

chunsch
Copy link
Contributor

@chunsch chunsch commented Nov 21, 2022 •
edited

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?) @ant-design/compatible import style and theme method

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English export style method
🇨🇳 Chinese 导出 style 相关方法

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@github-actions
Copy link
Contributor

github-actions bot commented Nov 21, 2022 •
edited

@chunsch chunsch mentioned this pull request Nov 21, 2022
Closed
@MadCcc
Copy link
Member

MadCcc commented Nov 21, 2022

这些零零散散的 export 出去还是会改变用户的代码，并且像 formatToken 并不是一个我们希望用户直接使用的方法。
如果 cjs 相关问题持续增加的话还是得考虑把 lib 加回来了。

@chunsch
Copy link
Contributor Author

chunsch commented Nov 21, 2022 •
edited

@MadCcc 嗯嗯，暂时把这个 PR 关了。目前来看，把 lib 加回来，确实更具备兼容性。

@chunsch chunsch closed this Nov 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@chunsch @MadCcc