Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Table children expand icons shouldn't be same line with parent's icon #38823

Merged
merged 1 commit into from Nov 22, 2022

Conversation

turdiyev
Copy link
Contributor

@turdiyev turdiyev commented Nov 21, 2022

To fix this issue just replaced float: left; and 'margin-top to 'vertical-align: middle.

and design table expand demo

Related issue link
fix #38713

@github-actions
Copy link
Contributor

github-actions bot commented Nov 21, 2022

@afc163
Copy link
Member

afc163 commented Nov 22, 2022

float 貌似是可行的,看看 4.x 的样式来改吧:https://4x.ant.design/components/table-cn/#components-table-demo-tree-data

@afc163
Copy link
Member

afc163 commented Nov 22, 2022

图片

row-indent 漏了 float: left

@codecov
Copy link

codecov bot commented Nov 22, 2022

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (b593eb9) compared to base (2de26c0).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff            @@
##            master    #38823   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          544       544           
  Lines         9352      9357    +5     
  Branches      2651      2651           
=========================================
+ Hits          9352      9357    +5     
Impacted Files Coverage Δ
components/table/style/expand.tsx 100.00% <ø> (ø)
components/empty/simple.tsx 100.00% <0.00%> (ø)
components/form/hooks/useFormItemStatus.ts 100.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@turdiyev
Copy link
Contributor Author

@afc163 are you chinese? Sorry i don't understand chinese. Even english is not my first language ))

Anyway okay, i will fix with float: left for row-indent

@turdiyev turdiyev force-pushed the expand-icon-indentation-issue branch from 018af8e to b593eb9 Compare November 22, 2022 06:55
@turdiyev
Copy link
Contributor Author

@afc163 so you can check now. I have removed previouse commit and commited new one.

@afc163
Copy link
Member

afc163 commented Nov 22, 2022

I think adding float: left style to .ant-table-row-indent would be a fix, just follow antd 4.x: https://4x.ant.design/components/table-cn/#components-table-demo-tree-data

@afc163 afc163 merged commit 870080b into ant-design:master Nov 22, 2022
This was referenced Nov 22, 2022
Copy link

@moshegazit moshegazit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is not work on rtl mode

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Table expand icon shouldn't be on same line with parent expand icon
3 participants