Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(badge): fix the style issue in RTL mode #38829

Merged
merged 8 commits into from Nov 22, 2022

Conversation

Wxh16144
Copy link
Member

@Wxh16144 Wxh16144 commented Nov 21, 2022

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

fix: #38806

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English fix the style issue in RTL mode
🇨🇳 Chinese 修复RTL模式下的样式问题

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@github-actions
Copy link
Contributor

github-actions bot commented Nov 21, 2022


[`&${ribbonPrefixCls}-placement-end`]: {
[`${ribbonPrefixCls}-corner`]: {
borderColor: 'currentcolor currentcolor transparent transparent',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这种可以拆成 borderInlineStartColor 等,遵循 logical-properties

@Wxh16144 Wxh16144 marked this pull request as ready for review November 22, 2022 05:41
@codecov
Copy link

codecov bot commented Nov 22, 2022

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (d477deb) compared to base (3040ed7).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff            @@
##            master    #38829   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          544       544           
  Lines         9356      9357    +1     
  Branches      2651      2651           
=========================================
+ Hits          9356      9357    +1     
Impacted Files Coverage Δ
components/form/hooks/useFormItemStatus.ts 100.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Wxh16144 Wxh16144 requested a review from MadCcc November 22, 2022 06:01
@afc163 afc163 merged commit e93f660 into ant-design:master Nov 22, 2022
@afc163 afc163 mentioned this pull request Nov 22, 2022
19 tasks
@Wxh16144 Wxh16144 deleted the wuxh/fix-38806 branch November 22, 2022 15:49
This was referenced Nov 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v5.x Badge RTL
3 participants