Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: context issues for Space.Compact #38870

Merged
merged 2 commits into from Nov 22, 2022
Merged

fix: context issues for Space.Compact #38870

merged 2 commits into from Nov 22, 2022

Conversation

foryuki
Copy link
Contributor

@foryuki foryuki commented Nov 22, 2022

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

close #38655
close #38812

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fix the style problem when the Space.Compact component wraps Modal, Dropdown, Drawer and other components.
🇨🇳 Chinese 修复 Space.Compact 组件嵌套 Modal,Dropdown,Drawer 等组件时的样式问题。

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@github-actions
Copy link
Contributor

github-actions bot commented Nov 22, 2022

@foryuki foryuki changed the title fix: context issues for Space.Compact WIP: fix: context issues for Space.Compact Nov 22, 2022
@foryuki foryuki changed the title WIP: fix: context issues for Space.Compact fix: context issues for Space.Compact Nov 22, 2022
@codecov
Copy link

codecov bot commented Nov 22, 2022

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (44d3d74) compared to base (b9cab0f).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff            @@
##            master    #38870   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          544       544           
  Lines         9357      9358    +1     
  Branches      2651      2652    +1     
=========================================
+ Hits          9357      9358    +1     
Impacted Files Coverage Δ
components/dropdown/dropdown.tsx 100.00% <ø> (ø)
components/drawer/index.tsx 100.00% <100.00%> (ø)
components/input-number/index.tsx 100.00% <100.00%> (ø)
components/modal/Modal.tsx 100.00% <100.00%> (ø)
components/dropdown/dropdown-button.tsx 100.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@afc163 afc163 merged commit 0b54a18 into ant-design:master Nov 22, 2022
@afc163
Copy link
Member

afc163 commented Nov 22, 2022

4.x-stable 也修复一下吧。

@foryuki
Copy link
Contributor Author

foryuki commented Nov 22, 2022

4.x-stable 也修复一下吧。

好👌

This was referenced Nov 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants