Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Space.Compact when wrapping a single child component #38896

Merged
merged 2 commits into from Nov 24, 2022

Conversation

foryuki
Copy link
Contributor

@foryuki foryuki commented Nov 23, 2022

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

#38590

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fix Space.Compact when wrapping a single child component.
🇨🇳 Chinese Space.Compact 包裹单个子组件时,展示该子组件本身的样式,不进行紧凑模式的样式定制。

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@github-actions
Copy link
Contributor

github-actions bot commented Nov 23, 2022

@zombieJ
Copy link
Member

zombieJ commented Nov 23, 2022

Test failed. Please check.

@foryuki foryuki changed the title fix: Space.Compact when wrapping a single child component WIP: fix: Space.Compact when wrapping a single child component Nov 23, 2022
@foryuki foryuki changed the title WIP: fix: Space.Compact when wrapping a single child component fix: Space.Compact when wrapping a single child component Nov 23, 2022
@foryuki foryuki changed the title fix: Space.Compact when wrapping a single child component WIP: fix: Space.Compact when wrapping a single child component Nov 23, 2022
@codecov
Copy link

codecov bot commented Nov 23, 2022

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (f52b84a) compared to base (5d9cb2e).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff            @@
##            master    #38896   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          544       544           
  Lines         9358      9358           
  Branches      2652      2652           
=========================================
  Hits          9358      9358           
Impacted Files Coverage Δ
components/style/compact-item-vertical.tsx 100.00% <ø> (ø)
components/style/compact-item.tsx 100.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@foryuki foryuki changed the title WIP: fix: Space.Compact when wrapping a single child component fix: Space.Compact when wrapping a single child component Nov 23, 2022
@afc163 afc163 merged commit 5fa56ec into ant-design:master Nov 24, 2022
@foryuki foryuki deleted the fix/space-compact-one-child branch November 24, 2022 05:31
This was referenced Nov 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants