Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: v5 dist/reset.css dropped in production mode #38956

Merged
merged 1 commit into from Nov 24, 2022

Conversation

murphy-wei
Copy link
Contributor

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English
🇨🇳 Chinese

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

根据文档

import { ConfigProvider } from 'antd'
import 'antd/dist/reset.css'

开发环境正常,生产环境下并没有引入该样式文件.

webpack说明:

Note that any imported file is subject to tree shaking. This means if you use something like css-loader in your project and import a CSS file, it needs to be added to the side effect list so it will not be unintentionally dropped in production mode:

https://webpack.js.org/guides/tree-shaking/#mark-the-file-as-side-effect-free

@github-actions
Copy link
Contributor

github-actions bot commented Nov 24, 2022

@github-actions
Copy link
Contributor

  • 🚨 Please fill changelog in the PR

    • Write with a developer-oriented perspective and narrative method, without describing the details of the repair
    • Describing the problem and the impact on the developer
    • describing the user-first site problem, not your solution
    • Refer: https://ant.design/changelog#4.9.0
  • 🚨 请填写 PR 中的 changelog

    • 请用面向开发者的角度叙述方式撰写,不描述修复细节
    • 描述问题和对开发者的影响
    • 描述用户第一现场的问题,而非你的解决方式
    • 参考:https://ant.design/changelog-cn#4.9.0

@yoyo837 yoyo837 closed this Nov 24, 2022
@yoyo837 yoyo837 reopened this Nov 24, 2022
@yoyo837
Copy link
Contributor

yoyo837 commented Nov 24, 2022

手误

package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Nov 24, 2022

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (69c0d00) compared to base (403d345).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff            @@
##            master    #38956   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          544       544           
  Lines         9350      9350           
  Branches      2649      2649           
=========================================
  Hits          9350      9350           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@afc163 afc163 merged commit 2a3cd3d into ant-design:master Nov 24, 2022
@MadCcc MadCcc mentioned this pull request Nov 25, 2022
19 tasks
@toFrankie
Copy link

请问什么时候更新?

@MadCcc MadCcc mentioned this pull request Nov 27, 2022
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants